Adds implementation of writer configuration #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds a writer configuration implementation that supports configuring both binary and text writer * Adds build_writer() with LazyEncoder which can be used to be build a writer based on given writer configuration * Removes write_as and write_all_as methods from element. Instead now LazyTextWriter can be used to write a Rust value as Ion. * Uses WriteConfig within to_binary and to_text methods of element API
zslayton
reviewed
Dec 5, 2023
…aikd-writer-config-impl
* Modifies element APIs to use raw text/bianry writers instead of lazy writer * Adds implementation of `WriteAsIon` for `Element` and implementation of `WriteAsIonValue` for `Value` * adds build API implementation for binary and text lazy writers * Puts `WriteConfig` under `experimental-lazy-reader` as it uses `Encoding`
|
Summary of new changes since last review:
|
zslayton
reviewed
Jan 18, 2024
zslayton
approved these changes
Jan 22, 2024
src/lazy/encoder/write_as_ion.rs
Outdated
Comment on lines
42
to
50
| let annotations = self.annotations().iter().collect::<Vec<&Symbol>>(); | ||
| if !annotations.is_empty() { | ||
| self.value() | ||
| .write_as_ion_value(writer.with_annotations(&annotations)) | ||
| } else { | ||
| self.value() | ||
| .write_as_ion_value(writer.without_annotations()) | ||
| } | ||
| } |
There was a problem hiding this comment.
We should add a pub(crate) way for this to access the Annotations' existing Vec so we don't have to collect() a new one. For now, you can optimize the no-annotations case a bit by doing:
if self.annotations().is_empty() {
self.value().write_as_ion_value(writer.without_annotations())
} else {
self.value.write_as_ion_value(writer.with_annotations(&Vec::from_iter(annotations.iter()))
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #618:
Description of changes:
Adds an implementation of a writer configuration that can be used to create a writer based on format and Ion version. This uses
LazyEncoderto build the writer using differentEncodings with differentbuild_writerimplementations.List of changes:
build_writer()withLazyEncoderwhich can be used to be build a writer based on given writer configurationLazy*Writercan be used to write a Rust value as Ion.WriteConfigwithinto_binaryandto_textmethods of element APIBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.