Raw 1.1 writer now clears encoding buffer on flush()
#871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zslayton
commented
Dec 5, 2024
Comment on lines
+82
to
+83
| // Now that we've written the encoding buffer's contents to output, clear it. | ||
| self.encoding_buffer_ptr = None; |
There was a problem hiding this comment.
This line was missing in the original impl, resulting in a dangling pointer. The second time flush() was called, the match arm on the old line 77 would incorrectly be taken.
jobarr-amzn
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #865.
The raw writer has an encoding buffer stored in its bump allocator.
As values are written, their serialized bytes are written to the encoding buffer.
When
flush()is called, the encoding buffer's bytes are copied to output and the bump allocator is reset.However, the writer was not clearing the
encoding_buffer_ptr, which continued to refer to a (now invalid) memory region in the bump.That memory still contained the old encoding buffer and so would result in the old data being written out again.
The 1.0 writer had the correct behavior and a cleaner implementation in general, so I copied it over.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.