Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes AnnotatableWriter and writer's symbol table experimentally pub #889

Merged
merged 4 commits into from
Dec 28, 2024

Conversation

zslayton
Copy link
Contributor

Fixes #887 and #888.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 77.85%. Comparing base (4e0d272) to head (4bd0ae4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/lazy/encoder/value_writer.rs 70.83% 0 Missing and 7 partials ⚠️
src/lazy/encoder/writer.rs 88.00% 3 Missing ⚠️
src/lazy/encoder/binary/v1_1/value_writer.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #889      +/-   ##
==========================================
- Coverage   77.85%   77.85%   -0.01%     
==========================================
  Files         136      136              
  Lines       34670    34703      +33     
  Branches    34670    34703      +33     
==========================================
+ Hits        26994    27017      +23     
- Misses       5680     5683       +3     
- Partials     1996     2003       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zslayton zslayton marked this pull request as ready for review December 26, 2024 16:48
@zslayton zslayton merged commit 75b0763 into main Dec 28, 2024
35 checks passed
@zslayton zslayton deleted the pub-symtab branch December 28, 2024 05:51
@barries
Copy link

barries commented Dec 29, 2024

Thanks, @zslayton! I wanted to attempt a PR for this, but seeing all that you did, I wouldn't have been familiar enough to make all the necessary tweaks. Very much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Writing annotated values with v1.1 BinaryWriter?
3 participants