Change update-motd.service to also set Wants=, fix typo, use RPM path macros #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
update-motd.serviceis currently not guaranteed to start after network-online.target and cloud-final.service have finished, but rather only after they have been started. This creates the possibility of a race condition where usuallyupdate-motd.serviceruns when these have finished, but sometimes they have not. If a MOTD script is dependent on something that is set up bycloud-final.serviceor the network takes slightly longer than normal to initialize, this would pose an issue some of the time.To prevent this, this PR also sets
Wants=, so thatupdate-motd.servicewon't start unless those services have finished starting or are not scheduled to start.This PR also fixes a typo in the description and changes the RPM spec to use macros for paths like /etc and /var/lib, which is the standard practice in RPM distros.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.