feat(test): for variables, #433

[Mte90]

As per #433

I am not sure if I added all of them, in the case of another scopethere is an error if the variable is not defined and it is part of the errors we are not checking right now (another ticket).

[Ph0enixKM]

@Mte90 please add all shorthand operators like +=, -=, *=, /=, %= as well as using variables by reference ref

[Mte90]

So like let var += 1?

[Ph0enixKM]

Yep, and do all that again for variables passed by reference:

fun foo(ref var) {
    var = 1
    var += 2
    // ...
}

[Mte90]

Added :-)

[Ph0enixKM]

@Mte90 the ref keyword is used to access variables by reference through function arguments. I feel like you misunderstood the functionality it provides.

If we use ref we can mutate certain value from the external environment. Here's an example of a function using reference and one that is not using references:

Reference

fun foo(ref arg) {
    arg = "foo"
}


let my_var = "test"
foo(my_var)
echo my_var // Outputs: "foo"

No reference

fun foo(arg) {
    arg = "foo"
}


let my_var = "test"
foo(my_var)
echo my_var // Outputs: "test"

[Mte90]

Updated, about ref I didn't knew about it. It is a fefature documented?

[Ph0enixKM]

@Mte90 yes, it is. Here in the documentation: https://docs.amber-lang.com/basic_syntax/functions#variable-references-ref

[Mte90]

Implemented ref that I didn't knew about it.

[Ph0enixKM]

In addition to that you should create a new test that is it's own separate file for checking non-ref shorthand operators:

let sum = 42
sum += 32
echo sum

let sub = 64
sub -= 48
echo sub

// ...

[Mte90]

We already have tests for shortand operators like in your example: https://github.com/amber-lang/amber/blob/master/src/tests/validity/shorthand_sub.ab

[Ph0enixKM]

Yeah... it seems that we already have tests for shorthand operators and ref shorthand operators.