Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve port following a specific order #75

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Conversation

kennedymwavu
Copy link
Contributor

closes #72

port to bind server on is now resolved in the following order of precedence:

  1. ambiorix.port.force R option (for belgic)
  2. AMBIORIX_PORT env var
  3. port argument (provided by user)
  4. SHINY_PORT env var (for shiny server et. al)
  5. random port

@kennedymwavu kennedymwavu linked an issue Oct 31, 2024 that may be closed by this pull request
@JohnCoene
Copy link
Collaborator

Looks good, thanks!

@JohnCoene JohnCoene merged commit 56e53bc into master Oct 31, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

validate port?
2 participants