Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[portinglayer] add a str field in the union for string data #130

Merged
merged 2 commits into from
Jun 7, 2023
Merged

[portinglayer] add a str field in the union for string data #130

merged 2 commits into from
Jun 7, 2023

Conversation

step0035
Copy link
Collaborator

@step0035 step0035 commented Jun 6, 2023

  • set maximum size of data to be 256 for string values
  • the increase in ram usage is not a problem as the event will be cleared after xQueueReceive successfully received and handled the data

@step0035 step0035 requested review from AdamZhang0124 and xshuqun June 6, 2023 06:35
@step0035
Copy link
Collaborator Author

step0035 commented Jun 7, 2023

@AdamZhang0124 @xshuqun , pls ignore the build check and merge
We want this PR to be included in Matter v1.2 TE#1
The change in Matter sdk that causes the ci build to fail is after TE#1

@xshuqun xshuqun merged commit 24be340 into main Jun 7, 2023
@xshuqun xshuqun deleted the fix_event_data_size branch June 7, 2023 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xshuqun xshuqun xshuqun approved these changes

@AdamZhang0124 AdamZhang0124 Awaiting requested review from AdamZhang0124

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@step0035 @xshuqun