Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[portinglayer] Matter data model #143

Merged
merged 29 commits into from
Aug 25, 2023
Merged

[portinglayer] Matter data model #143

merged 29 commits into from
Aug 25, 2023

Conversation

step0035
Copy link
Collaborator

@step0035 step0035 commented Jul 31, 2023

  • custom data model for ameba series
  • able to support dynamic endpoints
  • add device type endpoint presets and cluster presets
  • light_dm example that uses this ameba data model

@step0035 step0035 force-pushed the matter-data-model branch from 15e7ff6 to 9f65cbe Compare August 7, 2023 10:26
@step0035 step0035 marked this pull request as ready for review August 14, 2023 07:11
@step0035 step0035 requested a review from SirRu24 August 25, 2023 02:12
@xshuqun xshuqun merged commit befd3e4 into main Aug 25, 2023
Copy link
Collaborator

@SirRu24 SirRu24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matter_data_model.cpp, example_matter_light.cpp, matter_drivers.cpp, matter_drivers.h: Can change the style of pointer and reference declaration, not urgent
lib_chip_light_core.mk, lib_chip_light_main.mk: Clean the commented out line, I am not sure if it was intended to be left here or forget to delete

void matter_driver_on_identify_start(Identify * identify);
void matter_driver_on_identify_stop(Identify * identify);
void matter_driver_on_trigger_effect(Identify * identify);
void matter_driver_uplink_update_handler(AppEvent * event);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 11-14: update pointer declaration to int *ptr format

return;
}

void matter_driver_downlink_update_handler(AppEvent * event)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 80, 85, 90, 142: update pointer declaration to int *ptr format

$(CC) $(CFLAGS) $(INCLUDES) -c $< -MM -MT $@ -MF $(OBJ_DIR)/$(notdir $(patsubst %.o,%.d,$@))
cp $@ $(OBJ_DIR)/$(notdir $@)
# cp $*_$(TARGET).ii $(INFO_DIR)
# cp $*_$(TARGET).s $(INFO_DIR)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 15, 77, 263, 308, 353, 354, 361, 362: clean commented out codes

CXXFLAGS += -Wno-format-security

CXXFLAGS += -std=gnu++17
#CXXFLAGS += -std=c++14
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 70, 184, 221: clean commented out codes

{ DEVICE_TYPE_LO_ON_OFF_LIGHT, DEVICE_VERSION_DEFAULT },
};

Node& node = Node::getInstance();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update reference declaration to Node &node format


void Node::enableAllEndpoints()
{
for (Endpoint & endpoint: endpoints)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 36, 354, 367, 380, 393, 410, 423, 440, 453, 470, 490, 506, 519, 548, 559,
562, 567, 572, 584, 591, 605, 862, 871, 887, 896, 899, 904, 909, 921, 936, 974:
update reference declaration to Attribute &attribute format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants