[portinglayer] laundrywasher implementation #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
xshuqun
commented
Aug 24, 2023
xshuqun
commented
- add laundrywasher example in portinglayer
SirRu24
reviewed
Aug 25, 2023
There was a problem hiding this comment.
opstate_driver.cpp, opstate_driver.h, matter_drivers.cpp: Can change the style of pointer and reference declaration, not urgent
lib_chip_laundrywasher_core.mk, lib_chip_laundrywasher_mian.mk: Clean the commented out line, I am not sure if it was intended to be left here or forget to delete
zap file not tested yet
component/common/application/matter/example/laundrywasher/matter_drivers.cpp
Outdated
Show resolved
Hide resolved
component/common/application/matter/example/laundrywasher/matter_drivers.cpp
Show resolved
Hide resolved
component/common/application/matter/example/laundrywasher/lib_chip_laundrywasher_core.mk
Show resolved
Hide resolved
component/common/application/matter/example/laundrywasher/lib_chip_laundrywasher_main.mk
Outdated
Show resolved
Hide resolved
step0035
requested changes
Aug 25, 2023
* add laundrywasher example in portinglayer
* remove placeholder implementation comment * style check on pointer declaration and reference declaration
SandyYeow
approved these changes
Aug 31, 2023
step0035
approved these changes
Aug 31, 2023
SirRu24
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.