Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BLE] Update Matter BT API #32

Merged
merged 1 commit into from
Jan 5, 2023
Merged

[BLE] Update Matter BT API #32

merged 1 commit into from
Jan 5, 2023

Conversation

AdamZhang0124
Copy link
Collaborator

@AdamZhang0124 AdamZhang0124 commented Jan 3, 2023 •
edited
Loading

  • By deault, the Matter BLE mesh is disabled.
  • To enable Matter BLE mesh:
    1. Uncomment CFLAGS += -DCONFIG_MATTER_BLEMGR_ADAPTER = 1 in lib_chip.mk
    2. Uncomment BT_MATTER_MESH_ADAPTER = 1 in application.is.matter.mk

xshuqun
xshuqun reviewed Jan 4, 2023
View reviewed changes
Copy link
Collaborator

@xshuqun xshuqun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AdamZhang0124 could you please add some comments on how to enable the ble mesh for this new changes?

@AdamZhang0124
Copy link
Collaborator Author

Hi @xshuqun , please see this PR message

  • By deault, the Matter BLE mesh is disabled.

  • To enable Matter BLE mesh:

    1. Uncomment CFLAGS += -DCONFIG_MATTER_BLEMGR_ADAPTER = 1 in lib_chip.mk
    2. Uncomment BT_MATTER_MESH_ADAPTER = 1 in application.is.matter.mk

@AdamZhang0124 AdamZhang0124 requested a review from xshuqun January 4, 2023 04:09
xshuqun
xshuqun approved these changes Jan 5, 2023
View reviewed changes
Copy link
Collaborator

@xshuqun xshuqun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verification:
Default: commission and control OK
BLE-Mesh: commission and control OK

@xshuqun xshuqun merged commit e6a2c22 into main Jan 5, 2023
AdamZhang0124 added a commit that referenced this pull request Jan 5, 2023
@AdamZhang0124
[BLE] Update Matter BT API (#32)
f4af301
@step0035 step0035 deleted the update_ble_mesh branch January 5, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xshuqun xshuqun xshuqun approved these changes

@step0035 step0035 Awaiting requested review from step0035

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdamZhang0124 @xshuqun