Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Running with yarn creates a package.json with misconfigured dependencies #25

Closed
amclin opened this issue Oct 11, 2019 · 2 comments
Closed

Running with yarn creates a package.json with misconfigured dependencies #25

amclin opened this issue Oct 11, 2019 · 2 comments
Assignees
@amclin
Labels
bug Something isn't working released

Comments

@amclin
Copy link
Owner

amclin commented Oct 11, 2019

When running the project generator using yarn, the resulting package.json is built incorrectly. Dev Dependencies are incorrectly put into the "dependencies" list.

Blocks #18
@amclin amclin added the bug Something isn't working label Oct 11, 2019
@amclin amclin self-assigned this Oct 11, 2019
@amclin
Copy link
Owner Author

amclin commented Oct 11, 2019

Need to update the yarn installer to conditionally use yarn add -dev just like the npm installer conditionally uses npm install --save-dev

@amclin amclin closed this as completed in 27eccaf Oct 15, 2019
amclin pushed a commit that referenced this issue Oct 16, 2019
@semantic-release-bot
chore(release): 2.6.0 [skip ci]
21e42ad 
# [2.6.0](v2.5.1...v2.6.0) (2019-10-16)

### Bug Fixes

* running with yarn wasn't splitting dev dependencies ([27eccaf](27eccaf)), closes [#25](#25)

### Features

* **ci:** improve Travis configuration in generated project ([606e215](606e215))
@amclin
Copy link
Owner Author

amclin commented Oct 16, 2019

🎉 This issue has been resolved in version 2.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@amclin amclin

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@amclin