Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support looping videos #7

Closed
amclin opened this issue Oct 27, 2017 · 1 comment · Fixed by #42
Closed

Support looping videos #7

amclin opened this issue Oct 27, 2017 · 1 comment · Fixed by #42
Labels
enhancement released
Milestone
1.0

Comments

@amclin
Copy link
Owner

amclin commented Oct 27, 2017

Looping videos do not work. <video ... loop>

There is an error from the Scene7 SDK. Most likely this is because of a type conversion between the boolean true/false that videojs provides in options, and whatever value the S7 SDK expects as a parameter
@amclin amclin added this to the 1.0 milestone Oct 27, 2017
amclin added a commit that referenced this issue May 4, 2019
@amclin
feat: loops videos enabled with loop attribute
c00b922 
Fixes #7
amclin added a commit that referenced this issue May 4, 2019
@amclin
feat: loops videos enabled with loop attribute
8630a84 
Fixes #7
@amclin amclin mentioned this issue May 4, 2019
Merged
@amclin amclin closed this as completed in #42 May 4, 2019
@amclin
Copy link
Owner Author

amclin commented May 4, 2019

🎉 This issue has been resolved in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@amclin amclin added the released label May 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement released
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

feat: loops videos enabled with loop attribute amclin/videojs-scene7
1 participant
@amclin