Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NPU 2, 4, 5, 6 are from the same family. The only difference is firmware binary, PCIe revision ID.
Since NPU2 is the early prototype version, I move all of the shared code to npu4_family.h. The npu2 device might be obsoleted in the near future.
Ideally, after this change, if we have new data struct or macro to add, we should only update npu4_family.h and npu4_regs.c