Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ament_add_default_options (#390) #418

Open
wants to merge 1 commit into
base: humble
Choose a base branch
from

Conversation

hannes09
Copy link

  • Implement ament_add_default_options

Signed-off-by: methylDragon methylDragon@gmail.com

  • Mangle cmake_parse_arguments vars

Signed-off-by: methylDragon methylDragon@gmail.com

  • Unset macro variables at end

Signed-off-by: methylDragon methylDragon@gmail.com

  • Update comment and string

Signed-off-by: methylDragon methylDragon@gmail.com

  • Refine macro unsets

Signed-off-by: methylDragon methylDragon@gmail.com

* Implement ament_add_default_options

Signed-off-by: methylDragon <methylDragon@gmail.com>

* Mangle cmake_parse_arguments vars

Signed-off-by: methylDragon <methylDragon@gmail.com>

* Unset macro variables at end

Signed-off-by: methylDragon <methylDragon@gmail.com>

* Update comment and string

Signed-off-by: methylDragon <methylDragon@gmail.com>

* Refine macro unsets

Signed-off-by: methylDragon <methylDragon@gmail.com>
@hannes09
Copy link
Author

hannes09 commented Dec 17, 2022

backport of ament_add_default_options .
After backporting ament_add_default_options it would be possible to backport ros2/spdlog_vendor@4174be3
and ros2/yaml_cpp_vendor@16f9d25 to humble to fix static build.

@hannes09
Copy link
Author

hannes09 commented Jan 2, 2023

@mjeronimo Can you comment or accept the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants