Skip to content

Commit

Permalink
configure flake8 to check .py.in files
Browse files Browse the repository at this point in the history
  • Loading branch information
mikaelarguedas committed Aug 5, 2017
1 parent 776f05a commit 799682b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
5 changes: 4 additions & 1 deletion ament_cmake_flake8/cmake/ament_cmake_flake8_lint_hook.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@
# See the License for the specific language governing permissions and
# limitations under the License.

file(GLOB_RECURSE _python_files FOLLOW_SYMLINKS "*.py")
file(GLOB_RECURSE _python_files FOLLOW_SYMLINKS
"*.py"
"*.py.in"
)
if(_python_files)
message(STATUS "Added test 'flake8' to check Python code syntax and style conventions")
ament_flake8()
Expand Down
1 change: 1 addition & 0 deletions ament_flake8/ament_flake8/configuration/ament_flake8.ini
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
[flake8]
filename = *.py,*.py.in
ignore = D100,D101,D102,D103,D104,D105,D203,D212,D404
import-order-style = google
max-line-length = 99
Expand Down

2 comments on commit 799682b

@dirk-thomas
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikaelarguedas Can this branch be deleted?

@mikaelarguedas
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes now that we have an example of linting the generated files and not the templates themselves I will delete this alternative approach

Please sign in to comment.