Commits on Dec 5, 2019

1. Add line break after first open paren in multiline function call …

   Signed-off-by: Dan Rose <dan@digilabs.io>
   
   maintain alignment
   
   Signed-off-by: Dan Rose <dan@digilabs.io>
   
   Set indent_paren_open_brace=true
   
   Since we indent the arguments after a newline, this prevents a visual dedent when using a braced argument:
   
   BAD:
   ```
       ASSERT_THROW(
       {
         auto client = node->create_client<ListParameters>(
           "invalid_service?"
         );
       },
         rclcpp::exceptions::InvalidServiceNameError
       );
   ```
   GOOD:
   ```
       ASSERT_THROW(
         {
           auto client = node->create_client<ListParameters>(
             "invalid_service?"
           );
         },
         rclcpp::exceptions::InvalidServiceNameError
       );
   ```
   
   Signed-off-by: Dan Rose <dan@digilabs.io>
   
   Revert "Set indent_paren_open_brace=true"
   
   This reverts commit 49595c2.
   As it turns out, indent_paren_open_brace has other affects and the actual bug was indent_align_paren
   
   Signed-off-by: Dan Rose <dan@digilabs.io>

   

   rotu committed Dec 5, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for 97f1777
   • Browse repository at this point

   Copy the full SHA

   97f1777 View commit details

   Browse the repository at this point in the history