Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[foxy] Generate Setuptools Dict Helper Method #128

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

DLu
Copy link
Contributor

@DLu DLu commented Mar 1, 2021

#126 cherry-picked into Foxy!

@DLu DLu force-pushed the foxy_generate_setuptools branch from 31fb997 to 92b542c Compare March 2, 2021 01:49
@DLu DLu force-pushed the foxy_generate_setuptools branch from 92b542c to 001fd38 Compare March 10, 2021 16:24
Signed-off-by: David V. Lu <davidvlu@gmail.com>
@DLu DLu force-pushed the foxy_generate_setuptools branch from 001fd38 to ef966d2 Compare March 10, 2021 18:03
@DLu DLu mentioned this pull request Mar 10, 2021
@DLu
Copy link
Contributor Author

DLu commented Mar 10, 2021

Okay, finally ready for review @audrow

@audrow audrow self-assigned this Mar 11, 2021
@audrow audrow self-requested a review March 11, 2021 04:48
@audrow
Copy link
Contributor

audrow commented Mar 11, 2021

Just in case, since there's no PR job for this repo:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@audrow audrow merged commit 4e69bf1 into ament:foxy Mar 11, 2021
@audrow
Copy link
Contributor

audrow commented Mar 11, 2021

Thanks for the backport, @DLu!

@DLu DLu deleted the foxy_generate_setuptools branch March 12, 2021 03:54
@DLu
Copy link
Contributor Author

DLu commented Mar 12, 2021

Thanks for the merge! Could I get a new release as well?

@audrow
Copy link
Contributor

audrow commented Mar 12, 2021

Sure, I'll do it tomorrow.

@audrow
Copy link
Contributor

audrow commented Mar 12, 2021

Here's the release PR: ros/rosdistro#28628.

audrow pushed a commit that referenced this pull request Apr 19, 2021
This reverts commit 4e69bf1.

Signed-off-by: Audrow Nash <audrow@hey.com>
audrow pushed a commit that referenced this pull request Apr 20, 2021
This reverts commit 4e69bf1.

Signed-off-by: Audrow Nash <audrow@hey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants