Update to gtest 1.11 #21

clalancette · 2022-11-07T18:14:11Z

This matches the version that is in Ubuntu 22.04, and it should fix some warnings when building with Clang.

Draft for now while I get some feedback on it.

PiperOrigin-RevId: 334384310

…be_unintialized PiperOrigin-RevId: 334391149

Update comment to suggest using SetUpTestSuite and TearDownTestSuite. PiperOrigin-RevId: 334430329

Fix undefined pointer comparison PiperOrigin-RevId: 334436975

Update faq.md on underscore to mention `DISABLED_` prefix. PiperOrigin-RevId: 334507963

…k from A1, A2, ... to TArg1, TArg2,... to avoid clash with legacy header files

PiperOrigin-RevId: 335653055

PiperOrigin-RevId: 336087297

Make the code Python3 compliant. PiperOrigin-RevId: 336144198

Improve lookup of operator<< for user types Without this fix, trying to use this class with googletest struct Foo {}; template <typename OutputStream> OutputStream& operator<<(OutputStream& os, const Foo&) { os << "TemplatedStreamableInFoo"; return os; } results in an ambiguity error between the class' operator<< and the operator<< in gtest-printers.h removed in this CL. This fix also enables implicit conversions to happen, so that e.g. we will find the base class operator<< if a subclass has no operator<< of its own. PiperOrigin-RevId: 336261221

Add helper methos to internal FlatTuple. Refactor constructors. PiperOrigin-RevId: 336306681

Suggest using generic lambdas for composing macros. Long chains of macros hurt legibility; generic lambdas are an easy way to abbreviate them, but are not an obvious solution to casual users. Compare: EXPECT_THAT(f(), ElementsAre( Property(&MyClass::foo, Property(&OtherClass::bar, Contains("x"))), Property(&MyClass::foo, Property(&OtherClass::bar, Contains("y")))); to: EXPECT_THAT(f(), ElementsAre(HasFooBar("x"), HasFooBar("y"))); PiperOrigin-RevId: 336870137

Use absl::StrCat in MATCHER_P example for consistency with https://abseil.io/tips/3 PiperOrigin-RevId: 336878481

PiperOrigin-RevId: 336881266

Fixes AppVeyor by upgrading to Bazel 3.6.0 PiperOrigin-RevId: 336887434

Fix -Wmismatched-tags error with struct tuple_size vs class tuple_size PiperOrigin-RevId: 336930166

Prefer using over typedef. PiperOrigin-RevId: 337080404

Disable -Wmismatched-tags warning for struct/class tuple_size PiperOrigin-RevId: 337087493

Removing a semicolon that triggers a lint error in sample code. PiperOrigin-RevId: 337095451

Stop using master.zip to make the build reproducible PiperOrigin-RevId: 337102716

Disable warnings on code that intentionally tests a suboptimal syntax PiperOrigin-RevId: 337138442

Add ::testing::FieldsAre matcher for objects that support get<> and structured bindings. PiperOrigin-RevId: 337165285

…plate-args-AX-to-TArgX PiperOrigin-RevId: 337217118

Fixes build warnings from previous CL Add CMake to internal presubmit to prevent these PiperOrigin-RevId: 337325504

Fix some issues when running fuse_gmock_files. The module path should be updated before importing `fuse_gtest_files`, since the script may not run from the googletest repo root. We also need a non-frozen set in order to track progress. PiperOrigin-RevId: 337380466

Fix typo in the "Assertion Placement" section PiperOrigin-RevId: 337435223

Replace "definedin in" by "defined in" in files: - googletest/src/gtest.cc - googletest/test/googletest-output-test-golden-lin.txt

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

clalancette · 2022-11-07T19:14:43Z

CI just to see if things are happy with this:

Linux
Linux-aarch64
Windows

clalancette · 2022-12-20T19:33:36Z

Another try:

Linux
Linux-aarch64
Windows

ChrisThrasher

This updating is holding back MoveIt2 from using -Wpedantic. I can confirm that this works and lets us finally enable that warning.

clalancette · 2023-01-26T22:25:52Z

Unfortunately it is still causing CI to be yellow, and I haven't had time to go back and look at why. If you have some time to look at that and propose possible fixes, that would be helpful.

ChrisThrasher · 2023-01-26T22:57:17Z

https://ci.ros2.org/job/ci_linux/17846/gcc/new/source.3769323b-695d-4413-a06b-0a8173357ff9/#316

The error seems to be that there's some new code in v1.11 that triggers -Wmaybe-uninitialized. I think this was fixed in v1.12. Because GTest headers should be treated as system headers and thus no warnings get emitted in them, is this something we need to worry about?

clalancette · 2023-01-27T15:12:54Z

The error seems to be that there's some new code in v1.11 that triggers -Wmaybe-uninitialized. I think this was fixed in v1.12. Because GTest headers should be treated as system headers and thus no warnings get emitted in them, is this something we need to worry about?

You are right, nowadays we are treating them as system headers, so this probably isn't a problem anymore.

That said, this change is not compiling anymore locally for me. I had to upgrade a bunch of our packages to C++17 (which we honestly should have done a while ago). I'm slowly getting those PRs in, but this will take some time. Once we have those in, I'll rebase this and try CI again.

ChrisThrasher · 2023-01-27T16:37:14Z

That said, this change is not compiling anymore locally for me. I had to upgrade a bunch of our packages to C++17

Did this update accidentally start using C++17 features? The latest release only claims to require C++14. What specifically fails to compile for you?

clalancette · 2023-02-01T14:59:17Z

What specifically fails to compile for you?

When I go to compile this PR against the rest of the ROS 2 core, rcutils fails to build:

$ colcon build --event-handlers console_direct+ --packages-up-to rcutils
...
Starting >>> rcutils
...
/usr/bin/ld: CMakeFiles/test_allocator.dir/test/test_allocator.cpp.o: in function `TestAllocatorFixture_test_default_allocator_normal_Test::TestBody()':
test_allocator.cpp:(.text+0x38c): undefined reference to `osrf_testing_tools_cpp::memory_tools::on_unexpected_malloc(std::variant<std::function<void (osrf_testing_tools_cpp::memory_tools::MemoryToolsService&)>, std::function<void ()>, decltype(nullptr)>)'
/usr/bin/ld: test_allocator.cpp:(.text+0x3c2): undefined reference to `osrf_testing_tools_cpp::memory_tools::on_unexpected_realloc(std::variant<std::function<void (osrf_testing_tools_cpp::memory_tools::MemoryToolsService&)>, std::function<void ()>, decltype(nullptr)>)'
/usr/bin/ld: test_allocator.cpp:(.text+0x3f8): undefined reference to `osrf_testing_tools_cpp::memory_tools::on_unexpected_calloc(std::variant<std::function<void (osrf_testing_tools_cpp::memory_tools::MemoryToolsService&)>, std::function<void ()>, decltype(nullptr)>)'
/usr/bin/ld: test_allocator.cpp:(.text+0x42e): undefined reference to `osrf_testing_tools_cpp::memory_tools::on_unexpected_free(std::variant<std::function<void (osrf_testing_tools_cpp::memory_tools::MemoryToolsService&)>, std::function<void ()>, decltype(nullptr)>)'
collect2: error: ld returned 1 exit status
gmake[2]: *** [CMakeFiles/test_allocator.dir/build.make:101: test_allocator] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:455: CMakeFiles/test_allocator.dir/all] Error 2

ChrisThrasher · 2023-02-01T18:56:57Z

osrf_testing_tools_cpp is using std::variant from C++17 but isn't specifying that it requires C++17. That may be related to this error you're getting although I'd expect that to manifest at compile time, not link time.

https://github.com/osrf/osrf_testing_tools_cpp/blob/master/osrf_testing_tools_cpp/CMakeLists.txt#L9

clalancette · 2023-03-20T14:57:16Z

OK, we've now updated osrf_testing_tools_cpp to use C++17. Let's give CI another shot here:

Linux
Linux-aarch64
Windows

cottsay

A few things:

This needs a rebase or merge to take changes to the package manifest from rolling
The CMakeLists.txt.upstream should be updated within the googletest and googlemock subdirectories - this appears to have been lost in the merge.
The version snapshot list in the package manifests immediately prior to the version number should be updated with the new google/googletest ref

cottsay · 2023-04-06T15:43:15Z

I'm not sure why, but GitHub failed to back-link from the other PR.

This is the bug fix in osrf_testing_tools_cpp for the variant issue: osrf/osrf_testing_tools_cpp#77

Signed-off-by: Chris Lalancette <clalancette@gmail.com>

clalancette · 2023-06-23T13:48:47Z

I think I've now fixed all of the issues pointed out by @cottsay. With the other fixes that are in place, let's see how CI does now:

Linux
Linux-aarch64
Windows

clalancette · 2023-06-26T17:00:34Z

All right, with ros2/rclcpp#2227 now merged, I'm going to mark this PR as ready for review and run another CI on it.

clalancette · 2023-06-26T17:01:02Z

CI:

Linux
Linux-aarch64
Windows

cottsay

I reviewed the diff and it aligns with my attempt to do the same.

Thanks!

clalancette · 2023-06-27T11:56:01Z

CI is green, and this is approved, so merging. Note that I am going to create a merge commit here.

suertreus and others added 30 commits September 29, 2020 20:47

Merge pull request google#3027 from keshavgbpecdelhi:patch-2

f278076

PiperOrigin-RevId: 334384310

Merge pull request google#3024 from Thomas-Barbier-1A:fix_warning_may…

a0cbbba

…be_unintialized PiperOrigin-RevId: 334391149

Googletest export

2ff8d94

Update comment to suggest using SetUpTestSuite and TearDownTestSuite. PiperOrigin-RevId: 334430329

Googletest export

477998e

Fix undefined pointer comparison PiperOrigin-RevId: 334436975

A slight Gramatical change.

ed17c8c

Googletest export

1fb1bb2

Update faq.md on underscore to mention `DISABLED_` prefix. PiperOrigin-RevId: 334507963

Issue 2135: Change template args in NiceMock, NaggyMock and StrictMoc…

ee66065

…k from A1, A2, ... to TArg1, TArg2,... to avoid clash with legacy header files

Merge pull request google#3030 from ranodeepbanerjee:patch-1

07f4869

PiperOrigin-RevId: 335653055

Improve FilePath::Normalize method

113ca75

Fix a typo

870a6b5

Merge pull request google#2837 from inazarenko:duck_type_protos

4abb012

PiperOrigin-RevId: 336087297

Googletest export

72512aa

Make the code Python3 compliant. PiperOrigin-RevId: 336144198

Googletest export

2cf1f99

Add helper methos to internal FlatTuple. Refactor constructors. PiperOrigin-RevId: 336306681

Googletest export

d4df326

Use absl::StrCat in MATCHER_P example for consistency with https://abseil.io/tips/3 PiperOrigin-RevId: 336878481

Merge pull request google#3050 from peternewman:patch-1

6abcfac

PiperOrigin-RevId: 336881266

Googletest export

b55f834

Fixes AppVeyor by upgrading to Bazel 3.6.0 PiperOrigin-RevId: 336887434

Googletest export

fb239f0

Fix -Wmismatched-tags error with struct tuple_size vs class tuple_size PiperOrigin-RevId: 336930166

Googletest export

b2cb220

Prefer using over typedef. PiperOrigin-RevId: 337080404

Googletest export

79dc0f2

Disable -Wmismatched-tags warning for struct/class tuple_size PiperOrigin-RevId: 337087493

Googletest export

8ccc5ec

Removing a semicolon that triggers a lint error in sample code. PiperOrigin-RevId: 337095451

Googletest export

7e7e944

Stop using master.zip to make the build reproducible PiperOrigin-RevId: 337102716

Googletest export

f3dbe3e

Disable warnings on code that intentionally tests a suboptimal syntax PiperOrigin-RevId: 337138442

Googletest export

a462188

Add ::testing::FieldsAre matcher for objects that support get<> and structured bindings. PiperOrigin-RevId: 337165285

Merge pull request google#3042 from Aralox:Issue-2135-modify-mock-tem…

ebbeee3

…plate-args-AX-to-TArgX PiperOrigin-RevId: 337217118

Googletest export

3c95bf5

Fixes build warnings from previous CL Add CMake to internal presubmit to prevent these PiperOrigin-RevId: 337325504

Googletest export

252ee42

Fix some issues when running fuse_gmock_files. The module path should be updated before importing `fuse_gtest_files`, since the script may not run from the googletest repo root. We also need a non-frozen set in order to track progress. PiperOrigin-RevId: 337380466

Googletest export

620659e

Fix typo in the "Assertion Placement" section PiperOrigin-RevId: 337435223

Fix typo "definedin in" => "defined in"

fe0ee53

Replace "definedin in" by "defined in" in files: - googletest/src/gtest.cc - googletest/test/googletest-output-test-golden-lin.txt

1.11.9000

bc45e54

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

clalancette mentioned this pull request Nov 7, 2022

Fix compiler warnings related to gtest/gmock ament/ament_cmake#408

Merged

This was referenced Nov 10, 2022

Fix clang-tidy issues moveit/moveit2#1706

Merged

Fix some more clang compiler warnings moveit/moveit2#1712

Merged

ChrisThrasher approved these changes Jan 26, 2023

View reviewed changes

cottsay requested changes Apr 6, 2023

View reviewed changes

clalancette added 2 commits June 23, 2023 13:40

Merge branch 'rolling' into clalancette/update-to-gtest-2.11

6fad29b

Fixes from review.

f709286

Signed-off-by: Chris Lalancette <clalancette@gmail.com>

clalancette mentioned this pull request Jun 23, 2023

add googletest/release-1.12.1.tar.gz osrf/osrf_testing_tools_cpp#83

Closed

clalancette linked an issue Jun 23, 2023 that may be closed by this pull request

Current Gmock generates a lot of warning on Ubuntu 22.04 with Clang #23

Closed

clalancette mentioned this pull request Jun 26, 2023

Revamp the test_subscription.cpp tests. ros2/rclcpp#2227

Merged

clalancette marked this pull request as ready for review June 26, 2023 17:00

cottsay approved these changes Jun 26, 2023

View reviewed changes

clalancette merged commit ad343ef into rolling Jun 27, 2023

clalancette deleted the clalancette/update-to-gtest-1.11 branch June 27, 2023 11:56

sea-bass mentioned this pull request Jul 7, 2023

Mark Incomplete trajectories as failure PickNikRobotics/moveit_task_constructor#4

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to gtest 1.11 #21

Update to gtest 1.11 #21

clalancette commented Nov 7, 2022

clalancette commented Nov 7, 2022 •

edited

Loading

clalancette commented Dec 20, 2022

ChrisThrasher left a comment

clalancette commented Jan 26, 2023

ChrisThrasher commented Jan 26, 2023

clalancette commented Jan 27, 2023

ChrisThrasher commented Jan 27, 2023

clalancette commented Feb 1, 2023

ChrisThrasher commented Feb 1, 2023 •

edited

Loading

clalancette commented Mar 20, 2023

cottsay left a comment

cottsay commented Apr 6, 2023

clalancette commented Jun 23, 2023 •

edited

Loading

clalancette commented Jun 26, 2023

clalancette commented Jun 26, 2023 •

edited

Loading

cottsay left a comment

clalancette commented Jun 27, 2023

Update to gtest 1.11 #21

Update to gtest 1.11 #21

Conversation

clalancette commented Nov 7, 2022

clalancette commented Nov 7, 2022 • edited Loading

clalancette commented Dec 20, 2022

ChrisThrasher left a comment

Choose a reason for hiding this comment

clalancette commented Jan 26, 2023

ChrisThrasher commented Jan 26, 2023

clalancette commented Jan 27, 2023

ChrisThrasher commented Jan 27, 2023

clalancette commented Feb 1, 2023

ChrisThrasher commented Feb 1, 2023 • edited Loading

clalancette commented Mar 20, 2023

cottsay left a comment

Choose a reason for hiding this comment

cottsay commented Apr 6, 2023

clalancette commented Jun 23, 2023 • edited Loading

clalancette commented Jun 26, 2023

clalancette commented Jun 26, 2023 • edited Loading

cottsay left a comment

Choose a reason for hiding this comment

clalancette commented Jun 27, 2023

clalancette commented Nov 7, 2022 •

edited

Loading

ChrisThrasher commented Feb 1, 2023 •

edited

Loading

clalancette commented Jun 23, 2023 •

edited

Loading

clalancette commented Jun 26, 2023 •

edited

Loading