Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to gtest 1.14 #27

Merged
merged 592 commits into from
Feb 9, 2024
Merged

Update to gtest 1.14 #27

merged 592 commits into from
Feb 9, 2024

Conversation

clalancette
Copy link

This matches the version that will be in Ubuntu 24.04, and should resolve some CMake warnings when building on that platform.

@marcoag please take a look at this and osrf/osrf_testing_tools_cpp#84 when you get a chance.

dinord and others added 30 commits October 17, 2022 10:39
@dinord @copybara-github
Add Windows CI script
88c5975 
PiperOrigin-RevId: 481680362
Change-Id: I87b2b71427a8ad2603f5445d6ef794c3fa84746e
@copybara-github
Merge pull request google#4037 from KloolK:patch-1
6d71d90 
PiperOrigin-RevId: 481734961
Change-Id: I629dc1ca3b10bf5fc6afc179b651a09081f5c919
@derekmauro @copybara-github
Fix detection of the no_sanitize("hwaddress") attribute
26d3ab5 
PiperOrigin-RevId: 481765573
Change-Id: I1ba829c3cbf364a51d3ba383ee3b474c0e109578
@copybara-github
Adds Win32 UNC path support to FilePath::IsAbsolutePath() and FilePat…
f372c76 
…h::IsRootDirectory() in GoogleTest

Fixes: google#3025
PiperOrigin-RevId: 481932601
Change-Id: I90fcb5b3d189aea79a0fd18735bad038b3511270
@copybara-github
CMake: Add GTEST_HAS_ABSL build option for using Absl
6bad847 
PiperOrigin-RevId: 482101793
Change-Id: I1bd140fd6a325f573c8a0c464e4dccd4acd0d0a3
@copybara-github
Merge pull request google#4036 from zloylos:fix-output-json-3884
e07617d 
PiperOrigin-RevId: 482287697
Change-Id: I1179a1570cd64fcb156bda26e5c779b876c51742
Allow naming expectations google#3970
f3eb2b7 
Signed-off-by: Denis Hananein <i@zloylos.me>
Change messages
0d26378 
Signed-off-by: Denis Hananein <i@zloylos.me>
Fix format without expectation name
09e1c64 
Signed-off-by: Denis Hananein <i@zloylos.me>
@copybara-github
Clarify that parameter generator does not evaluate immediately
03597a0 
This aims to avoid confusion as to what kinds of computations are valid inside
a parameter generator expression, calling out flags as a supported use case.

PiperOrigin-RevId: 483397027
Change-Id: I2d036fae95120d617f30a5566ea7498ce1f9bfb6
@dinord @copybara-github
Use git commit hash in CMake quickstart
90171d1 
Commit hashes reflect GoogleTest's live-at-head stance.
Credits to @shinfd.
Fixes google#4000

PiperOrigin-RevId: 483655943
Change-Id: Ieeb162859348dbe3657e18f283bac81412f2585d
@copybara-github
Merge pull request google#4041 from zloylos:allow-naming-expectations
3026483 
PiperOrigin-RevId: 483683590
Change-Id: Id22de3a22018324e5c1e21e262ac5e027a83bf3e
@copybara-github
Add documentation for --gunit_recreate_environments_when_repeating.
66366ce 
PiperOrigin-RevId: 485895339
Change-Id: I09b0f535941531ef7bcb74593d385891d56b3e32
@copybara-github
Fix typo in documentation of ConvertGenerator()
a4f02ef 
PiperOrigin-RevId: 486316328
Change-Id: I91d5d5ba1aaf4a4ab14019c8963e7fe181722f95
@copybara-github
RecordProperty serializes ints and 64-bit ints, including size_ts
386c766 
PiperOrigin-RevId: 486685761
Change-Id: I164d2646e65670d341dbf437ee571953c456677a
@copybara-github
Remove incorrect GTEST_ATTRIBUTE_UNUSED_ from InSequence class.
6b63c98 
Fixes: google#4048
PiperOrigin-RevId: 486951561
Change-Id: I4fae101b5ac5ed4f46c32aba8c36519e1f784db1
@copybara-github
Merge pull request google#4039 from zloylos:fix-return-fail-at-4038
44c0364 
PiperOrigin-RevId: 487516335
Change-Id: Ib475750586fc7e6ab01729f65253e3a86916b994
Support kitty TERM
4b7f945 
Signed-off-by: Denis Hananein <i@zloylos.me>
@copybara-github
Defined a testing::SrcDir() function that returns the name of a direc…
912db74 
…tory

where ancillary data files can be found.

PiperOrigin-RevId: 487896836
Change-Id: Ie6b1ba734e900fa33872b63090879ee6efe33411
@hxm-cpp
fixing gcc.gnu domain redirection
9c990a7
@hxm-cpp
148ab82
@copybara-github
Merge pull request google#4060 from RerEngineer:main
42c6f57 
PiperOrigin-RevId: 488456139
Change-Id: I648f3d2c6affadfea27214a6a22cacc576971cef
@copybara-github
Merge pull request google#4058 from zloylos:support-kitty-term
0e6aac2 
PiperOrigin-RevId: 488463135
Change-Id: I4180d766dabbe438210904e743e6e963122540f5
@copybara-github
Remove incorrect usage of GTEST_ATTRIBUTE_UNUSED_ on classes.
4408a02 
Fixes: google#4054
PiperOrigin-RevId: 488721587
Change-Id: I8742d8475376635c83edcf524796a6107042e89b
@copybara-github
When printing floating-point numbers, print full precision by default.
9c33214 
To make debug output readable, we still use the faster 6-digit precision
sometimes, but only if it will round-trip.

This way, when a test fails due to a very small difference in floating-point
numbers, users will have enough digits to see the difference.

PiperOrigin-RevId: 488958311
Change-Id: Ibcac43f48a97006d89217530c69386cc4fa2735c
Change MakeUnique -> std::make_unique in docs
834698c
@copybara-github
Merge pull request google#4066 from zloylos:doc/make_uniq
519beb0 
PiperOrigin-RevId: 490057649
Change-Id: Ia788d55cfbc576e841064b8e907f8671cc46f3bf
@copybara-github
This commit fixes a minor verb conjugation error in gmock_cook_book.md.
e68764c 
PiperOrigin-RevId: 490601453
Change-Id: I733b2ed8740b1c809dddb166a42993b869198469
@copybara-github
Disables -Wunused-member-function and -Wused-but-marked-unused th…
a16bfcf 
…at trigger via `MOCK_METHOD()` and `EXPECT_THAT()` macros.

Fixes: google#4052, google#4055
PiperOrigin-RevId: 491647393
Change-Id: I8e2ad838156fa8c7e9dccd1740af797e694992b6
@copybara-github
Make SizeIsMatcher::Impl conform to the contract of MatcherDescriberI…
1f643f7 
…nterface.

MatcherDescriberInterface specifies that DescribeTo "should print a verb phrase", but "size ..." is not a verb phrase. Currently, ElementsAre(SizeIs(9)) is described as "has 1 element that size is equal to 9". With this change, it will be described as "has 1 element that has a size that is equal to 9".

PiperOrigin-RevId: 492022324
Change-Id: I4083335f2419462464957521c1e033643b53b763
smr99 and others added 19 commits July 3, 2023 21:23
@smr99
Use template type FloatType in the cast.
3044657
@copybara-github
Update docstring of PrintWithFallback(..) to reflect the recently cha…
4a1a299 
…nged ordering.

PiperOrigin-RevId: 546373360
Change-Id: I2538b45d8c7710592071cc352da6771480c324e6
@kimvaleen
Fixed variables that could be declared 'const'
c88e0b4
@copybara-github
Merge pull request google#4308 from smr99:fix-float-cast
cc36671 
PiperOrigin-RevId: 547250378
Change-Id: I084c30e45f331cb296535822923da1cb7e848e11
@copybara-github
Merge pull request google#4302 from ciband:feat/nrf52
c541e7c 
PiperOrigin-RevId: 549006105
Change-Id: Ifbe2bf57e10df4c71e51dbfaf1687f4f621f5106
@copybara-github
Merge pull request google#4313 from kimvaleen:main
d66ce58 
PiperOrigin-RevId: 549039222
Change-Id: I96bea310beede5ba0ed6160155251ffd9d7a2103
@mrfeod
Fix typo in gmock_cook_book.md
f014396
@derekmauro @copybara-github
Remove unused cast implementation
1ed6a8c 
PiperOrigin-RevId: 549456180
Change-Id: I10862e6de981087a5c590cccf6152255e9a176a0
@copybara-github
Make AbslStringify usage public in GoogleTest
01e1837 
Fixes google#4314

PiperOrigin-RevId: 549986457
Change-Id: Iff74f02ab1c106696f288540e9c623d56b76e3f7
@copybara-github
Merge pull request google#4317 from mrfeod:patch-1
40412d8 
PiperOrigin-RevId: 550585850
Change-Id: I727f74aeb6f1da5bbbf5a5f49f06c4cfea40a73b
@copybara-github
Adjust includes to use <> instead of "", consistent with quickstart p…
c875c4e 
…ages.

Right now, gtest documentation uses different #include syntax. The quickstart
pages (e.g., http://google.github.io/googletest/quickstart-bazel.html#create-and-run-a-binary) are checked in with `#include <gtest/gtest.h>` However, other
documentation (such as the primer) uses `#include "gtest/gtest.h"` (e.g.,
https://google.github.io/googletest/primer.html#writing-the-main-function).

PiperOrigin-RevId: 551878641
Change-Id: Iab93cc1da3ef4870a07b624071b75d6e9d3568c1
@juliencombattelli
Use #if and not #ifdef to check filesystem support
efe6bb1
@copybara-github
Merge pull request google#4325 from juliencombattelli:main
6f6ab42 
PiperOrigin-RevId: 552577282
Change-Id: I2b4d20d155ad5746e36711c039293d5c996a332e
@derekmauro @copybara-github
Update GoogleTest dependencies
717d8ab 
PiperOrigin-RevId: 552912819
Change-Id: If1b6278f7fe5a8fc41fc3bc390356a94387d0091
@pl98 @copybara-github
Make testing::Message support streamed AbslStringify values
e7fd109 
This allows types that provide an AbslStringify definition to be streamed into GoogleTest macros.

PiperOrigin-RevId: 552914482
Change-Id: I5fb386980d4d24873f95f0a8ef83067a6a3c86ac
@derekmauro @copybara-github
Add googletest-message-test to the Bazel tests
58e37f7 
It appears to have been unintentionally left out

PiperOrigin-RevId: 553141410
Change-Id: I8adac55a3df0ec12d6fe03446f71858fc702e178
@derekmauro @copybara-github
Remove the GTEST_HAS_DOWNCAST_ customization point.
96683ee 
PiperOrigin-RevId: 553150809
Change-Id: I10d19a45a85c5f63a5e65dc322413307116e1c25
@derekmauro @copybara-github
Bump version to v1.14 in preparation for release
f8d7d77 
PiperOrigin-RevId: 553152072
Change-Id: I0bfbb2da6b3902fc3e41a8e1c4aacb291ffdd098
@clalancette
Merge tag 'v1.14.0' into clalancette/update-to-1.14
a474223
@clalancette clalancette mentioned this pull request Jan 18, 2024
Merged
@clalancette
Update to 1.14.9000
27c4483 
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@marcoag
Copy link

marcoag commented Jan 19, 2024 •
edited
Loading

I did a local build with no issues, LGTM.

Note: I can't review or mark the approval since I'm not assigned.

@clalancette
Copy link
Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette
Copy link
Author

clalancette commented Feb 6, 2024 •
edited
Loading

With the fixes from osrf/osrf_testing_tools_cpp#84 in place, here is another shot at CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

mjcarroll
mjcarroll approved these changes Feb 9, 2024
View reviewed changes
Copy link

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+24,365/-27,822

LGTM

@clalancette clalancette merged commit 449327b into rolling Feb 9, 2024
1 of 7 checks passed
@clalancette clalancette deleted the clalancette/update-to-1.14 branch February 9, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@ahcorde ahcorde ahcorde approved these changes

@cottsay cottsay Awaiting requested review from cottsay cottsay is a code owner

Assignees

@clalancette clalancette

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.