Skip to content
This repository has been archived by the owner on Dec 10, 2020. It is now read-only.

Uncrustify 0.66.1 #21

Merged
merged 204 commits into from
Mar 1, 2018
Merged

Uncrustify 0.66.1 #21

merged 204 commits into from
Mar 1, 2018

Conversation

dirk-thomas
Copy link

Pulling in bug fixes and improvements up to the latest release 0.66.1 of uncrustify. This version will also be available in Ubuntu Bionic. Replaces #20.

CDanU and others added 30 commits June 21, 2017 16:45
Some mode debug lines
This adds two options:
*nl_func_call_empty - same as nl_func_decl_empty but for
function calls
*nl_func_call_paren_empty - same as nl_func_def_paren_empty
but for function calls

Change-Id: Ib49ca03b18043368ceeb96e2c6f4fcfed3928ccb
CT_IGNORED comment may not be changed
Renaming nl_func_def to nl_func_def_or_call because it now
deals with newlines in function calls.

Change-Id: Ifd601f7b483edb2b3443ce421298c17b0064596e
Creating intermediate directories for the output file can sometimes
lead to 'Unable to create d:: Permission denied (13)' error in Windows.
This happens when Uncrustify try to create a Windows drive letter.
This does not affect the creation of the path, but prints annoying messages.
This patch fixes this issue.
Fix 'Permission denied' during output path creation
Fixed uncrustify#1366 - Wrong indentation of the break in switch
Add options for empty function calls and rename nl_func_def method
…ment

 Fix indent comment alignment rule 3
These options have similar descriptions:
*sp_after_operator_sym_empty - Have precedence of...
*nl_typedef_blk_start - takes preference over...
*nl_func_paren_empty - Overrides...

This change modifies these descriptions to use the
"override" wording. This doesn't make any changes to
the options like sp_before_unnamed_ptr_star, where if it's
set to ignore, another options is used, and isn't really
overridden.

Change-Id: I47ecd54c4ed3f3950a15052ef86f4caabe8ffbdf
Type: Code Improvement
…criptions

Standardize option descriptions to "override"
add ellipsis (...) punctuator to objective-C
Checking '_MSC_VER' sets '__func__' to "???", which is incorrect for GCC.
The use of cpd.pass_count is not necessary.
Add missing Objective-C nullability keywords. Make nullable, nonnull and
null_unspecified of type CT_TYPE because they are used before parameter
types in method declarations. Handle them in properties correctly by
changing CT_TYPE to CT_OC_PROPERTY_ATTR where necessary.

Remove LANG_C flag from C++-only keywords.

Add Objective-C BOOL type.
@dirk-thomas
Copy link
Author

CI builds only running the uncrustify linter tests:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Ready for review.

@dirk-thomas
Copy link
Author

Waiting for review.

@dirk-thomas dirk-thomas added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Mar 1, 2018
@dirk-thomas dirk-thomas merged commit 4a51784 into master Mar 1, 2018
@dirk-thomas dirk-thomas deleted the uncrustify_0.66.1 branch March 1, 2018 17:00
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Mar 1, 2018
@mikaelarguedas
Copy link

This introduced a new warning on windows: https://ci.ros2.org/job/ci_windows/4096/warnings43Result/new/

@dirk-thomas dirk-thomas mentioned this pull request Mar 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.