Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin Uncrustify version to 0.67 #2

Closed
wants to merge 1 commit into from
Closed

Pin Uncrustify version to 0.67 #2

wants to merge 1 commit into from

Conversation

jacobperron
Copy link
Contributor

Do not use newer versions.

With this change we can be sure the same version of Uncrustify is being used on all platforms.

Resolves ros2/rosidl#340

@jacobperron
Pin Uncrustify version to 0.67
603ed04 
Do not use newer versions.
@jacobperron jacobperron added the in progress Actively being worked on (Kanban column) label Dec 18, 2018
@jacobperron
Copy link
Contributor Author

jacobperron commented Dec 18, 2018 •
edited
Loading

Test on macOS with uncrustify v0.68 installed:
Build Status (cppcheck errors expected)

@jacobperron jacobperron mentioned this pull request Dec 19, 2018
Merged
@jacobperron
Copy link
Contributor Author

Closing in favour of #3

@jacobperron jacobperron deleted the strict_uncrustify_version branch December 19, 2018 22:54
@jacobperron jacobperron removed the in progress Actively being worked on (Kanban column) label Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jacobperron