Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FRQ: gsd/gromacs reader - basic features #47

Closed
3 tasks done
kay-ro opened this issue Jul 11, 2024 · 3 comments · Fixed by #70
Closed
3 tasks done

FRQ: gsd/gromacs reader - basic features #47

kay-ro opened this issue Jul 11, 2024 · 3 comments · Fixed by #70
Assignees
Labels
module: load module: reader new feature New feature release: minor Issues that need to be addressed in a minor release status: ready for review Needs to be reviewed

Comments

@kay-ro
Copy link
Member

kay-ro commented Jul 11, 2024

Proposed new feature or change:

Basic features of gsd and gromacs readers to be implemented in AMEP as a minor release:

The new data such as molecule_id, molecule_type will be saved in the h5amep format as dataset in each frame.

(id) type mol_id mol_type charge coordinates ...
(1)    c1    1           coh            0.29      ....
2      c2    1           coh            0.0      ....
3      o1    1           coh            0.0      ....
4      h1    1           coh            -0.29      ....
5      c1    2           coh            0.29      ....
6      c2    2           coh            0.0      ....
7      o1    2           coh            0.0      ....
8      h1    2           coh            -0.29      ....
...
@kay-ro kay-ro added new feature New feature release: minor Issues that need to be addressed in a minor release status: to do Issues that someone needs to work on module: load module: reader labels Jul 11, 2024
@kay-ro kay-ro added this to the release v1.1.0 milestone Jul 11, 2024
@kay-ro
Copy link
Member Author

kay-ro commented Jul 24, 2024

GSD reader TODOs:

@kay-ro kay-ro added status: in progress Someone is working on this issue and removed status: to do Issues that someone needs to work on labels Jul 24, 2024
@kay-ro
Copy link
Member Author

kay-ro commented Sep 24, 2024

current issue very slow import times. Looking for solutions also with other readers.

@kay-ro
Copy link
Member Author

kay-ro commented Oct 17, 2024

MDAnalysis has outstandingly fast reader. Will stay with Chemfiles reader for now. Reasonable import times. For very large trajectories the initial reading by chemfiles (not storing it in h5amep format) may take several minutes.

@kay-ro kay-ro added status: ready for review Needs to be reviewed and removed status: in progress Someone is working on this issue labels Oct 17, 2024
kay-ro pushed a commit that referenced this issue Oct 18, 2024
@kay-ro kay-ro linked a pull request Oct 21, 2024 that will close this issue
@kay-ro kay-ro closed this as completed Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: load module: reader new feature New feature release: minor Issues that need to be addressed in a minor release status: ready for review Needs to be reviewed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants