Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: LammpsReader angmom not imported #52

Closed
kay-ro opened this issue Aug 20, 2024 · 0 comments · Fixed by #53
Closed

BUG: LammpsReader angmom not imported #52

kay-ro opened this issue Aug 20, 2024 · 0 comments · Fixed by #53
Assignees
@kay-ro
Labels
bug Something isn't working module: reader release: patch Issues that need to be addressed in a patch release status: done Done and ready to merge
Milestone
release v1.0.3

Comments

@kay-ro
Copy link
Member

kay-ro commented Aug 20, 2024

Description:

In reader.LammpsReader the angular momentum is read from the dump files but there is no dataset created in the h5amep file.

Code for reproduction:

traj[0].angmom()

Error message:

No response

Python and AMEP versions:

amep 1.0.2

Additional information:

No response

How did you install AMEP?

None
@kay-ro kay-ro added bug Something isn't working release: patch Issues that need to be addressed in a patch release status: in progress Someone is working on this issue module: reader labels Aug 20, 2024
@kay-ro kay-ro added this to the release v1.0.3 milestone Aug 20, 2024
@kay-ro kay-ro self-assigned this Aug 20, 2024
@kay-ro kay-ro added the status: done Done and ready to merge label Aug 20, 2024
kay-ro pushed a commit that referenced this issue Aug 20, 2024
added angmom to hdf5 file, fixes #52
a77c712
@kay-ro kay-ro linked a pull request Aug 20, 2024 that will close this issue
Bug patches kayro #53
Merged
@kay-ro kay-ro removed the status: in progress Someone is working on this issue label Aug 20, 2024
@kay-ro kay-ro closed this as completed Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kay-ro kay-ro

Labels
bug Something isn't working module: reader release: patch Issues that need to be addressed in a patch release status: done Done and ready to merge
Projects
None yet
Milestone
release v1.0.3
Development

Successfully merging a pull request may close this issue.

Bug patches kayro amepproject/amep
1 participant
@kay-ro