Swap Node Sass (deprecated) for Dart Sass #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
node-sass: https://www.npmjs.com/package/node-sass dart-sass: https://www.npmjs.com/package/sass Dart Sass supports a JavaScript API that's fully compatible with Node Sass, with a few exceptions: - no `precision` option - no `sourceComments` option - the `outputStyle` option is limited to "expanded" and "compressed" So while this is a breaking change, it would be possible to support both Node Sass (deprecated) and Dart Sass by adding a new parameter to `karma-scss-preprocessor` which accepts a Sass implementation. Since Node Sass is deprecated however it may be better to switch without adding a new option.
notlee
added a commit
to Financial-Times/origami-build-tools
that referenced
this pull request
Feb 8, 2021
Karma is currently using node-sass which may cause errors when running `npm test` if the component under test relied on dart sass features (e.g. relies on `_index.scss` to resolve imports) Currently relies on an embeded, modified version of `karma-scss-preprocessor`. There is an upstream PR which we may be able to switch to if it's accepted: amercier/karma-scss-preprocessor#73
notlee
added a commit
to Financial-Times/origami-build-tools
that referenced
this pull request
Feb 8, 2021
Karma is currently using node-sass which may cause errors when running `npm test` if the component under test relied on dart sass features (e.g. relies on `_index.scss` to resolve imports) Currently relies on an embeded, modified version of `karma-scss-preprocessor`. There is an upstream PR which we may be able to switch to if it's accepted: amercier/karma-scss-preprocessor#73
notlee
added a commit
to Financial-Times/origami-build-tools
that referenced
this pull request
Feb 8, 2021
Karma is currently using node-sass which may cause errors when running `npm test` if the component under test relied on dart sass features (e.g. relies on `_index.scss` to resolve imports) Currently relies on an embedded, modified version of `karma-scss-preprocessor`. There is an upstream PR which we may be able to switch to if it's accepted: amercier/karma-scss-preprocessor#73
notlee
added a commit
to Financial-Times/origami-build-tools
that referenced
this pull request
Feb 8, 2021
Karma is currently using node-sass which may cause errors when running `npm test` if the component under test relied on dart sass features (e.g. relies on `_index.scss` to resolve imports) Currently relies on an embedded, modified version of `karma-scss-preprocessor`. There is an upstream PR which we may be able to switch to if it's accepted: amercier/karma-scss-preprocessor#73
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋 thanks for your work on
karma-scss-preprocessor! Would you be open to a pull request which switches from node-sass (deprecated) to dart-sass?node-sass: https://www.npmjs.com/package/node-sass
dart-sass: https://www.npmjs.com/package/sass
Dart Sass supports a JavaScript API that's fully compatible with Node
Sass, with a few exceptions:
precisionoptionsourceCommentsoptionoutputStyleoption is limited to "expanded" and "compressed"So while this is a breaking change, it would be possible to support
both Node Sass (deprecated) and Dart Sass by adding a new parameter
to
karma-scss-preprocessorwhich accepts a Sass implementation.Since Node Sass is deprecated however it may be better to switch
without adding a new option.