Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(workflow): Test on 16.x and 18.x #58

Merged
merged 2 commits into from
May 23, 2022
Merged

Conversation

code-forger
Copy link
Member

@code-forger code-forger commented May 19, 2022

Start testing on 16.x and 18.x

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • My changes are in sync with the code style of this project.
  • There aren't any other open Pull Requests for the same issue/update.
  • These changes should be applied to a maintenance branch.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using Fetchye?

Developers will be able to trust the code works on higher versions of node

@code-forger code-forger requested review from a team as code owners May 19, 2022 11:26
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 19, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a901214:

Sandbox Source
quick-install Configuration
fetchye-provider-install Configuration
fetchye-redux-provider-install Configuration
nextjs-fetchye-ssr Configuration

@10xLaCroixDrinker 10xLaCroixDrinker requested a review from a team May 23, 2022 17:33
@bishnubista bishnubista merged commit f96b4b6 into main May 23, 2022
@bishnubista bishnubista deleted the code-forger-patch-1 branch May 23, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants