Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(eslint): upgrade eslint and config #62

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Conversation

code-forger
Copy link
Member

Description

update eslint and config to latest

Motivation and Context

Keeps the coding standard up to scratch, which means our code continues to be the quality we want

How Has This Been Tested?

as no semantic changes were made, only unit tests were run.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • My changes are in sync with the code style of this project.
  • There aren't any other open Pull Requests for the same issue/update.
  • These changes should be applied to a maintenance branch.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using Fetchye?

N/A

@Matthew-Mallimo Matthew-Mallimo requested a review from a team July 12, 2022 13:26
giulianok
giulianok previously approved these changes Jul 12, 2022
@code-forger code-forger dismissed stale reviews from giulianok and Matthew-Mallimo via 4eb2af3 July 14, 2022 15:34
@code-forger code-forger force-pushed the chore/lint-upgrade branch 2 times, most recently from 4eb2af3 to dd32992 Compare July 14, 2022 15:44
BREAKING: this drops support for NodeJS v10
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 12e0101:

Sandbox Source
quick-install Configuration
fetchye-provider-install Configuration
fetchye-redux-provider-install Configuration
nextjs-fetchye-ssr Configuration

@code-forger
Copy link
Member Author

Note: Node 10.x check is no-longer expected. It will not run.

@10xLaCroixDrinker 10xLaCroixDrinker requested a review from a team July 14, 2022 17:01
@code-forger code-forger merged commit 639f34e into main Jul 18, 2022
@code-forger code-forger deleted the chore/lint-upgrade branch July 18, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants