docs(readme): update sequenced api example #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6b944f0:
|
Matthew-Mallimo
previously approved these changes
Feb 22, 2023
JAdshead
reviewed
Feb 22, 2023
| ```jsx | ||
| import React from 'react'; | ||
| import { useFetchye } from 'fetchye'; | ||
|
|
||
| const MyFavoriteBook = () => { | ||
| const { isLoading: loadingProfile, data: profile } = useFetchye('http://example.com/api/profile'); | ||
| const { isLoading: loadingBook, data: favoriteBook } = useFetchye(() => `http://example.com/api/books/${profile.body.favoriteBookId}`); |
There was a problem hiding this comment.
this example relies on an error being thrown Cannot read properties of undefined . I think the defer example will be easier to understand.
Might still be worth having an example of useFetchye receiving a function instead of a string
There was a problem hiding this comment.
Updated to include original style example
JAdshead
reviewed
Feb 23, 2023
Co-authored-by: Jonny Adshead <JAdshead@users.noreply.github.com>
Matthew-Mallimo
approved these changes
Feb 24, 2023
JAdshead
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The sequenced api example resulted in multiple calls from the 'second' api in the sequence, these api calls were malformed, as the input required from the 'first' api in the sequence was not available yet.
How Has This Been Tested?
Locally in a module
Types of Changes
Checklist:
What is the Impact to Developers Using Fetchye?
Improved example on how to call sequenced api calls