This repository has been archived by the owner on May 15, 2024. It is now read-only.
Feat/conditional native intl #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10xLaCroixDrinker
approved these changes
Feb 29, 2024
giulianok
approved these changes
Mar 4, 2024
Matthew-Mallimo
approved these changes
Mar 6, 2024
oneamexbot
added a commit
that referenced
this pull request
Mar 6, 2024
# [4.5.0](v4.4.4...v4.5.0) (2024-03-06) ### Features * **conditionalIntl:** added useNativeIntl to updateLocale ([#76](#76)) ([e2301a3](e2301a3))
|
🎉 This PR is included in version 4.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed the
updateLocalefunction so that it will work consistently with the One App environment variableONE_CONFIG_USE_NATIVE_INTL.Motivation and Context
This makes the environment variable consistent in not including Lean-Intl. When the environment variable is enabled,
updateLocalewill still dispatch the action to update the active locale but not add the Lean-Intl bundles.Relevant One App PR: americanexpress/one-app#1258
How Has This Been Tested?
Ran the changes in a test module along with the branch in the One App PR. Validated that using
updateLocalewith the environment variable set to true would not add the bundle, but would update the active locale and switches locales forreact-intl.Types of Changes
Checklist:
What is the Impact to Developers Using one-app-ducks?
When using the
ONE_CONFIG_USE_NATIVE_INTLenvironment variable, Lean-Intl bundles will not get added when usingupdateLocale.