This repository has been archived by the owner on May 3, 2024. It is now read-only.
feat(conditionalIntl): added env var for Itnl #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
Matthew-Mallimo
suggested changes
Jan 29, 2024
10xLaCroixDrinker
suggested changes
Jan 30, 2024
There was a problem hiding this comment.
This also requires changes to one-app-ducks to prevent loading intl polyfill locale packs when using native Intl https://github.com/americanexpress/one-app-ducks/blob/main/src/intl/index.js#L436
Matthew-Mallimo
previously approved these changes
Feb 5, 2024
13 tasks
|
@timBarton96 one-app-ducks@4.5.0 has been released. Please include this upgrade in this PR! |
Matthew-Mallimo
previously approved these changes
Mar 6, 2024
10xLaCroixDrinker
suggested changes
Mar 6, 2024
Matthew-Mallimo
previously approved these changes
Mar 6, 2024
10xLaCroixDrinker
previously approved these changes
Mar 6, 2024
auto-merge was automatically disabled
March 8, 2024 09:27
Head branch was pushed to by a user without write access
timBarton96
dismissed stale reviews from 10xLaCroixDrinker and Matthew-Mallimo
via
617ec89
code-forger
force-pushed
the
feat/conditionalIntlPolyfill
branch
from
808d2ec to
a5a231b
Compare
Matthew-Mallimo
approved these changes
Mar 26, 2024
code-forger
approved these changes
Mar 26, 2024
JAdshead
reviewed
Mar 26, 2024
| @@ -236,6 +240,12 @@ export function getHead({ | |||
| `; | |||
| } | |||
|
|
|||
| export function renderEnvironmentVariables(nonce) { | |||
There was a problem hiding this comment.
just a naming nitpick, renderEnvironmentVariables indicates that its a standard practice to include, right now this is okay but could lead to issues in the future
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added an environment variable to conditionally add the lean-intl polyfill.
Motivation and Context
The lean-intl polyfill is missing Intl fetres and this PR is for consumers of one-app that want to trade compatibility with older browsers for these Intl features. The environment variable defaults to enable lean-intl polyfill, so needs to be explicitly be disabled. By disalbing the polyfill, the Intl implementations of the browsers are used and for modern browsers, this means extended functionality.
How Has This Been Tested?
I served a test-module which uses Luxon which uses Intl for its timezones functionality. The timezones would not work without the env var, but when the env var is enabled and there is no lean-intl the timezones work.
Types of Changes
Checklist:
What is the Impact to Developers Using One App?
Developers will now have the option to opt out of using lean-intl.