Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

Commit

Permalink
Revert "refactor(node): upgrade to node 20"
Browse files Browse the repository at this point in the history
This reverts commit c65151d.
  • Loading branch information
Matthew-Mallimo authored Mar 22, 2024
1 parent c65151d commit 1c8c9f1
Show file tree
Hide file tree
Showing 14 changed files with 4,663 additions and 6,305 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/bundle-size.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 20.x
node-version: 16.x
- uses: preactjs/compressed-size-action@v2
env:
NODE_ENV: development
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [18.x, 20.x]
node-version: [16.x]
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/on-pr_dangerJS.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: '16.x'
- uses: actions/cache@v4
with:
path: ~/.npm
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/on-pr_one-app-integration-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
${{ runner.os }}-node-
- uses: actions/setup-node@v4
with:
node-version: 20.x
node-version: 16.x
- name: npm install
run: NODE_ENV=development npm ci
- name: Build docker image
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
${{ runner.os }}-node-
- uses: actions/setup-node@v4
with:
node-version: 20.x
node-version: 16.x
- name: One App release
id: vars
run: |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
# Setup .npmrc file to publish to npm
- uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: '16.x'
registry-url: 'https://registry.npmjs.org'
- name: Docker login
run: echo "${{ secrets.DOCKER_PASSWORD }}" | docker login --username ${{ secrets.DOCKER_USER }} --password-stdin
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
20.11.1
18.17.1
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
# which includes build utils preinstalled (e.g. gcc, make, etc).
# This will result in faster and reliable One App docker image
# builds as we do not have to run apk installs for alpine.
FROM node:20 as builder
FROM node:18.17.1 as builder
WORKDIR /opt/build
RUN npm install -g npm@10 --registry=https://registry.npmjs.org
RUN npm install -g npm@9.6.7 --registry=https://registry.npmjs.org
COPY --chown=node:node ./ /opt/build
# npm ci does not run postinstall with root account
RUN NODE_ENV=development npm ci --build-from-source
Expand Down
2 changes: 0 additions & 2 deletions __tests__/integration/__snapshots__/one-app.spec.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,6 @@ Array [
"nodejs_active_handles_total",
"nodejs_active_requests",
"nodejs_active_requests_total",
"nodejs_active_resources",
"nodejs_active_resources_total",
"nodejs_eventloop_lag_max_seconds",
"nodejs_eventloop_lag_mean_seconds",
"nodejs_eventloop_lag_min_seconds",
Expand Down
4 changes: 2 additions & 2 deletions docs/guides/Publishing-Modules.md
Original file line number Diff line number Diff line change
Expand Up @@ -123,10 +123,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Use Node.js 20.x
- name: Use Node.js 16.x
uses: actions/setup-node@v1
with:
node-version: '20.x'
node-version: '16.x'
- name: Cache NPM Dependencies
uses: actions/cache@v1
with:
Expand Down
Loading

0 comments on commit 1c8c9f1

Please sign in to comment.