This repository has been archived by the owner on May 3, 2024. It is now read-only.
fix(watchLocalModules): fix missing baseUrl #1391
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes users seeing the following log when re-building locally served modules running the dev server:
Encountered error fetching module at undefinedmodule-config.json: Only absolute URLs are supported
Motivation and Context
This bug means the module-config.json will never load, and the users sees an error they have no way of understanding
How Has This Been Tested?
running agains reproduction case
unit tests
Types of Changes
Checklist:
What is the Impact to Developers Using One App?
No more confusing log