Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

fix(watchLocalModules): fix missing baseUrl #1391

Merged

Conversation

code-forger
Copy link
Member

Description

This fixes users seeing the following log when re-building locally served modules running the dev server:
Encountered error fetching module at undefinedmodule-config.json: Only absolute URLs are supported

Motivation and Context

This bug means the module-config.json will never load, and the users sees an error they have no way of understanding

How Has This Been Tested?

running agains reproduction case
unit tests

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

No more confusing log

Copy link
Contributor

Size Change: 0 B

Total Size: 232 kB

ℹ️ View Unchanged
Filename Size
./build/app/app.js 38.2 kB
./build/app/app~vendors.js 129 kB
./build/app/runtime.js 5.64 kB
./build/app/service-worker-client.js 5.46 kB
./build/app/vendors.js 54.1 kB

compressed-size-action

@smackfu smackfu requested a review from a team April 18, 2024 12:29
@PixnBits
Copy link
Contributor

PixnBits commented Apr 18, 2024

this is also addressed in #1370 by using the in-memory module map instead of reading from disk and redoing other ingestion tasks

@10xLaCroixDrinker 10xLaCroixDrinker merged commit f301288 into main Apr 19, 2024
10 checks passed
@10xLaCroixDrinker 10xLaCroixDrinker deleted the fix/undefined-base-url-in-local-module-watcher branch April 19, 2024 03:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants