This repository has been archived by the owner on May 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o feature/fastify-logging
…express/one-app into feature/enable-otel-in-v6
10xLaCroixDrinker
changed the title
Enable OpenTelemetry in v6
Enable OpenTelemetry logging in v6
Aug 23, 2023
Size Change: 0 B Total Size: 710 kB ℹ️ View Unchanged
|
Matthew-Mallimo
suggested changes
Aug 24, 2023
…express/one-app into feature/enable-otel-in-v6
…o feature/enable-otel-in-v6
Matthew-Mallimo
approved these changes
Sep 22, 2023
JAdshead
approved these changes
Sep 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #1084, pairs with #1059
Description
Added otel transport
Motivation and Context
Enable logs to be sent to OTel collector.
There is a bug that is currently blocking instrumentation, and a limitation on the otel transport that required a bit of a hack for sending otel logs to console in development. (Both documented in code comments)
How Has This Been Tested?
Ran locally with prod sample sending logs to local collector. Yet to test in higher environments. Hold merging until then
Types of Changes
Checklist:
What is the Impact to Developers Using One App?
Adds ability to use open telemetry for logs