Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

chore(package): bump holocron to 1.8.1 #1128

Closed

Conversation

drewcur
Copy link

@drewcur drewcur commented Sep 11, 2023

Update to latest holocron version.

Description

Update to latest holocron that has additional console warnings and need installed into the app to be available to the modules.

Motivation and Context

Allows modules to access this version via the bundler.

How Has This Been Tested?

npm packed the library and installed it into the app to see it working.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

Will see more warnings in console and on logging services when modules fail during load server side. The warnings represent existing issues.

@Matthew-Mallimo Matthew-Mallimo requested a review from a team September 12, 2023 13:42
@JAdshead
Copy link
Contributor

closing as no change after updating.

@JAdshead JAdshead closed this Sep 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants