This repository has been archived by the owner on May 3, 2024. It is now read-only.
chore(package): bump holocron to 1.8.1 #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewcur
force-pushed
the
chore/bump-holocron-1.8.1-5.x.x
branch
from
eae7fc5 to
7314d77
Compare
Matthew-Mallimo
previously approved these changes
Sep 12, 2023
drewcur
force-pushed
the
chore/bump-holocron-1.8.1-5.x.x
branch
from
7314d77 to
e3690f8
Compare
drewcur
commented
Sep 19, 2023
| )); | ||
| ); | ||
| registerModule('root-module', RootModule); | ||
| RenderModule.mockImplementation(() => <RootModule />); |
There was a problem hiding this comment.
Updated to bypass the check against state that cannot be manually set.
Matthew-Mallimo
approved these changes
Sep 19, 2023
10xLaCroixDrinker
approved these changes
Sep 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to latest holocron version.
Description
Update to latest holocron that has additional console warnings and need installed into the app to be available to the modules.
Motivation and Context
Allows modules to access this version via the bundler.
How Has This Been Tested?
npm packed the library and installed it into the app to see it working.
Types of Changes
Checklist:
What is the Impact to Developers Using One App?
Will see more warnings in console and on logging services when modules fail during load server side. The warnings represent existing issues.