-
Notifications
You must be signed in to change notification settings - Fork 87
chore(deps): bump prom-client from 14.2.0 to 15.1.0 #1272
chore(deps): bump prom-client from 14.2.0 to 15.1.0 #1272
Conversation
070efd2
to
ca5eda8
Compare
Bumps [prom-client](https://github.com/siimon/prom-client) from 14.2.0 to 15.1.0. - [Release notes](https://github.com/siimon/prom-client/releases) - [Changelog](https://github.com/siimon/prom-client/blob/master/CHANGELOG.md) - [Commits](siimon/prom-client@v14.2.0...v15.1.0) --- updated-dependencies: - dependency-name: prom-client dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
ca5eda8
to
1afd9d1
Compare
if (!gauges[name]) { | ||
throw new Error(`unable to find gauge ${name}, please create it first`); | ||
} | ||
gauges[name].reset(...args); | ||
gauges[name].reset(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function doesn't take any arguments, and didn't in v14 either
Size Change: 0 B Total Size: 718 kB ℹ️ View Unchanged
|
|
||
function load() { | ||
jest.resetModules(); | ||
|
||
jest.mock('prom-client'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An internal, non-breaking change to prom-client
broke this mock.
createGauge({ name: 'yup', help: 'yup_help', labelNames: ['foo'] }); | ||
const gauge = register._metrics.yup; | ||
expect(gauge.hashMap).toEqual({}); | ||
incrementGauge('yup', { foo: 'bar' }, 2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An object of labels (defined at metric creation) is the only other valid argument
…ps://github.com/americanexpress/one-app into dependabot/npm_and_yarn/main/prom-client-15.1.0
954de06
@@ -58,6 +59,7 @@ async function appPlugin(fastify) { | |||
fastify.register(fastifyMetrics, { | |||
defaultMetrics: { enabled: false }, | |||
endpoint: null, | |||
promClient: client, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fastify-metrics has prom-client@14 as a dependency, so it was charing the same installed version before. With the prom-client update fastify-metrics was using its own instance of prom-client, so the metrics would not come through. This change allows us to get around that by providing our prom-client instance to fastify-metrics
Bumps prom-client from 14.2.0 to 15.1.0.
Release notes
Sourced from prom-client's releases.
... (truncated)
Changelog
Sourced from prom-client's changelog.
Commits
5adf350
15.1.016b0292
chore: update changelog for release17f49db
chore: run CI on Node 21 (#602)50d49a6
chore: upgrade prettier to v3 (#601)1bc99bd
feat: update type declarations0a77ca1
feat: implement startTimerWithExemplar15767e3
test: add failing test casec171309
src: fix type of collectDefaultMetrics.metricsList2ffd316
pushgateway: adds configuration for omitting job name (for gravel gateway com...efdb283
Improve performance ofhashObject
(#594)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)