Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

chore(node): drop node 16 #1280

Merged
merged 4 commits into from
Feb 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [16.x, 18.x]
node-version: [18.x, 20.x]
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down
4 changes: 2 additions & 2 deletions docs/guides/Publishing-Modules.md
Original file line number Diff line number Diff line change
Expand Up @@ -123,10 +123,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Use Node.js 16.x
- name: Use Node.js 18.x
uses: actions/setup-node@v1
with:
node-version: '16.x'
node-version: '18.x'
- name: Cache NPM Dependencies
uses: actions/cache@v1
with:
Expand Down
2 changes: 1 addition & 1 deletion docs/guides/Running-One-App-Locally.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

# Running One App Locally

To run One App locally, you need to make sure that you are on Node 16 or greater. After that, go ahead and clone One App:
To run One App locally, you need to make sure that you are on Node 18. After that, go ahead and clone One App:

```bash
git clone https://github.com/americanexpress/one-app.git
Expand Down
94 changes: 1 addition & 93 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 2 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "One Amex SPA technology stack.",
"main": "index.js",
"engines": {
"node": ">=16 <=18",
"node": ">=18 <=20",
"npm": ">=8"
},
"scripts": {
Expand All @@ -13,9 +13,7 @@
"clean:build": "rimraf dist lib build lastBuild.json stats.json",
"clean:test": "rimraf test-results",
"prebuild": "npm run clean:build",
"build:bundle": "if-node-version \">16\" && npm run build:bundle:gt-16 || npm run build:bundle:16",
"build:bundle:gt-16": "cross-env \"NODE_OPTIONS=--max-old-space-size=4096 --openssl-legacy-provider\" bundle-one-app",
"build:bundle:16": "cross-env NODE_OPTIONS=--max-old-space-size=4096 bundle-one-app",
"build:bundle": "cross-env \"NODE_OPTIONS=--max-old-space-size=4096 --openssl-legacy-provider\" bundle-one-app",
"build:server": "cross-env BABEL_ENV=server babel src --out-dir lib --ignore \"**/__mocks__\"",
"build:service-workers": "node scripts/build-service-workers.js",
"build:artifacts:statics": "node scripts/build-static-assets-artifact.js",
Expand Down Expand Up @@ -178,7 +176,6 @@
"https-proxy-agent": "^5.0.1",
"husky": "^8.0.1",
"if-env": "^1.0.4",
"if-node-version": "^1.1.1",
"jest": "^29.6.4",
"jest-circus": "^29.2.2",
"jest-environment-jsdom": "^28.1.2",
Expand Down
Loading