Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

Upgrading to Node.js 20 #1293

Merged
merged 12 commits into from
Mar 12, 2024
Merged

Upgrading to Node.js 20 #1293

merged 12 commits into from
Mar 12, 2024

Conversation

giulianok
Copy link
Member

@giulianok giulianok commented Feb 13, 2024

Description

Simply running One App on Node.js v20

Motivation and Context

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

Copy link
Contributor

github-actions bot commented Feb 13, 2024

Size Change: 0 B

Total Size: 719 kB

ℹ️ View Unchanged
Filename Size
./build/app/app.js 171 kB
./build/app/app~vendors.js 410 kB
./build/app/runtime.js 7.07 kB
./build/app/service-worker-client.js 7.25 kB
./build/app/vendors.js 123 kB

compressed-size-action

@giulianok giulianok marked this pull request as ready for review February 19, 2024 21:59
@giulianok giulianok requested review from a team as code owners February 19, 2024 21:59
JAdshead
JAdshead previously approved these changes Feb 26, 2024
bishnubista
bishnubista previously approved these changes Feb 27, 2024
@giulianok giulianok enabled auto-merge (squash) February 27, 2024 20:41
@giulianok giulianok disabled auto-merge February 27, 2024 21:32
@giulianok giulianok dismissed stale reviews from bishnubista and JAdshead via 8f78975 February 28, 2024 19:57
bishnubista
bishnubista previously approved these changes Feb 28, 2024
@@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [18.x, 20.x]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dropping support for 18 is a breaking change.

Comment on lines -7 to -8
"node": ">=18 <=20",
"npm": ">=8"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to still support node 18

Copy link
Contributor

@JAdshead JAdshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to still support node 18

@giulianok giulianok merged commit adbff4e into main Mar 12, 2024
9 checks passed
@giulianok giulianok deleted the refactor/upgrade-to-node-20 branch March 12, 2024 16:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants