Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

chore(docker): ignore build cache #1341

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

PixnBits
Copy link
Contributor

@PixnBits PixnBits commented Mar 25, 2024

Description

Ignore the build cache and stats when building the image.

Motivation and Context

The build cache [stats] can grow to hundreds of MBs. Ignoring it reduces the context transfer by two orders of magnitude, which is also a speedup of building the image.

Found this as the culprit using dive.

How Has This Been Tested?

Ran $ docker run . locally

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

Less time waiting if building the image locally.

it can grow to hundreds of MBs
ignoring reduces the context transfer by two orders of magnitude
Copy link
Contributor

Size Change: 0 B

Total Size: 735 kB

ℹ️ View Unchanged
Filename Size
./build/app/app.js 187 kB
./build/app/app~vendors.js 411 kB
./build/app/runtime.js 7.07 kB
./build/app/service-worker-client.js 7.25 kB
./build/app/vendors.js 123 kB

compressed-size-action

@Matthew-Mallimo Matthew-Mallimo merged commit 8e543f4 into main Mar 26, 2024
10 checks passed
@Matthew-Mallimo Matthew-Mallimo deleted the chore/docker-ignore-build-cache branch March 26, 2024 13:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants