Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

chore(actions): ignore dependabot #295

Merged
merged 4 commits into from
Sep 15, 2020
Merged

chore(actions): ignore dependabot #295

merged 4 commits into from
Sep 15, 2020

Conversation

nellyk
Copy link
Contributor

@nellyk nellyk commented Sep 4, 2020

Description

Dependabot generates commit messages that have more than 72 character and commitlint has it set to a max of 100 for commits (i don’t know how this worked for Travis CI -ideally they should have failed) #291 fails. They currently have an issue open for this dependabot/dependabot-core#2056. For the time being we can ignore running commit lint on dependant bot commit messages. using this

Motivation and Context

Enable us to merge dependabot PRs

How Has This Been Tested?

nellyk#132 - dependabot PR
nellyk#131 - normal PR

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

No impact

@nellyk nellyk requested review from a team as code owners September 4, 2020 15:15
@github-actions github-actions bot added the chore label Sep 4, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2020 •
edited
Loading

📊 Bundle Size Report

file name size on disk gzip
app.js 275.4KB 82.2KB
runtime.js 15KB 5.4KB
vendors.js 117.2KB 36.4KB
app~vendors.js 432.5KB 112.2KB
service-worker-client.js 17KB 5.2KB
legacy/app.js 290.7KB 85.4KB
legacy/runtime.js 15KB 5.4KB
legacy/vendors.js 172.7KB 47.1KB
legacy/app~vendors.js 441.3KB 114.5KB
legacy/service-worker-client.js 17.5KB 5.4KB

Generated by 🚫 dangerJS against dae4000

@nellyk nellyk merged commit 2a895be into master Sep 15, 2020
@nellyk nellyk deleted the chore/commit-lint-dependabot branch September 15, 2020 13:00
@felipecrs felipecrs mentioned this pull request Dec 23, 2020
Merged
felipecrs added a commit to felipecrs/bindl that referenced this pull request Dec 30, 2020
@felipecrs
ci(commitlint): disable commitlint for dependabot
f7de680 
Refs wagoid/commitlint-github-action#69

Refs dependabot/dependabot-core#2445

Refs: americanexpress/one-app#295
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtomcal mtomcal mtomcal approved these changes

@JAdshead JAdshead JAdshead approved these changes

@Francois-Esquire Francois-Esquire Francois-Esquire approved these changes

@infoxicator infoxicator infoxicator approved these changes

@shivaylamba shivaylamba shivaylamba approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nellyk @mtomcal @JAdshead @Francois-Esquire @infoxicator @shivaylamba