Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(scenarios): added scenario examples #145

Merged
merged 1 commit into from
Dec 9, 2021
Merged

chore(scenarios): added scenario examples #145

merged 1 commit into from
Dec 9, 2021

Conversation

Matthew-Mallimo
Copy link
Member

Description

Adds additional scenario examples for better documentation

Motivation and Context

Properly document all possible scenario structures

How Has This Been Tested?

N/A

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ x] Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • My changes are in sync with the code style of this project.
  • There aren't any other open Pull Requests for the same issue/update.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • This change impacts caching for client browsers.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using parrot?

@Matthew-Mallimo Matthew-Mallimo requested a review from a team as a code owner November 16, 2021 21:11
github-actions[bot]
github-actions bot reviewed Nov 16, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution to this repository. We will be reviewing your PR. In the meantime, please sign the CLA and make sure all status checks have passed.

10xLaCroixDrinker
10xLaCroixDrinker approved these changes Nov 29, 2021
View reviewed changes
SCENARIOS.md
{
request: '/ship_log',
request: '/ship_log', // If request is a string, the HTTP method defaults to GET
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually have an open issue for this #101

@10xLaCroixDrinker 10xLaCroixDrinker merged commit 33b132f into main Dec 9, 2021
@10xLaCroixDrinker 10xLaCroixDrinker deleted the chore/mockDocs branch December 9, 2021 01:47
JAdshead pushed a commit that referenced this pull request Feb 21, 2022
@Matthew-Mallimo @JAdshead
docs(scenarios): added scenario examples (#145)
31d19be
JAdshead pushed a commit that referenced this pull request Feb 21, 2022
@Matthew-Mallimo @JAdshead
docs(scenarios): added scenario examples (#145)
63cdbe7
JAdshead pushed a commit that referenced this pull request Feb 21, 2022
@Matthew-Mallimo @JAdshead
docs(scenarios): added scenario examples (#145)
67bfa9b
JAdshead pushed a commit that referenced this pull request Feb 21, 2022
@Matthew-Mallimo @JAdshead
docs(scenarios): added scenario examples (#145)
67026d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@JAdshead JAdshead JAdshead approved these changes

@10xLaCroixDrinker 10xLaCroixDrinker 10xLaCroixDrinker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Matthew-Mallimo @10xLaCroixDrinker @JAdshead