Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SEO component expects 'summary_with_large_image' instead of 'summary_large_image #24

Closed
jdaexp opened this issue Aug 17, 2020 · 2 comments · Fixed by #25
Closed

SEO component expects 'summary_with_large_image' instead of 'summary_large_image #24

jdaexp opened this issue Aug 17, 2020 · 2 comments · Fixed by #25
Labels
bug Something isn't working released

Comments

@jdaexp
Copy link

jdaexp commented Aug 17, 2020 •
edited
Loading

According to twitter sample code, the meta tag created to support large image cards should look like the following:
<meta name="twitter:card" content="summary_large_image">

However, react-seo is expecting the following:
card: 'summary_with_large_image'
@ghost ghost added the bug Something isn't working label Aug 17, 2020
@ghost
Copy link

ghost commented Aug 17, 2020

Thanks for the report.

I think the plan here is to add support summary_large_image and a deprecation warning for summary_with_large_image so that we don't break existing functionality.

ghost pushed a commit that referenced this issue Aug 17, 2020
fix(getTwitterCardTags): summary_large_image twitter card type
1cb41fc 
This change fixes support for summary_large_image Twitter Card type
which was incorrectly defined as summary_with_large_image.

Closes #24
@ghost ghost mentioned this issue Aug 17, 2020
Merged
@ghost ghost closed this as completed in #25 Aug 21, 2020
oneamexbot added a commit that referenced this issue Aug 21, 2020
@oneamexbot
chore(release): 2.2.1 [skip ci]
531e9d5 
## [2.2.1](v2.2.0...v2.2.1) (2020-08-21)

### Bug Fixes

* **getTwitterCardTags:** summary_large_image twitter card type ([1cb41fc](1cb41fc)), closes [#24](#24)
@oneamexbot
Copy link
Contributor

🎉 This issue has been resolved in version 2.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(getTwitterCardTags): summary_large_image twitter card type americanexpress/react-seo
2 participants
@oneamexbot @jdaexp