Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to amethyst 0.15 #12

Closed
wants to merge 1 commit into from
Closed

Conversation

mbStavola
Copy link

Amethyst recently published a 0.15 release, which unfortunately breaks this crate in a few ways:

image

Thankfully, it's only because of a transitive crate mismatch which we can fix by updating from Amethyst 0.14 to 0.15. No other changes are necessary.

Since this is likely a breaking change, I thought it might be appropriate to bump this crate to 0.7.0 instead of 0.6.2.

@Deedasmi
Copy link

Deedasmi commented Apr 18, 2020

+1, works fine. EDIT: I'd actually probably suggest that the version number match the Amethyst version, in this case 0.15.

@Deedasmi Deedasmi mentioned this pull request Apr 23, 2020
@FireFlyForLife
Copy link

I would also be in favor of bumping to 0.15.

@mbStavola
Copy link
Author

@Deedasmi @FireFlyForLife While I agree in principle, it doesn't appear to have been the standard for this crate.

If a maintainer is in favor, I'll gladly bump the version.

@jaynus
Copy link
Collaborator

jaynus commented Jun 4, 2020

closing in favor of #14

@jaynus jaynus closed this Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants