Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to jenkins CI #209

Merged
merged 1 commit into from
Sep 21, 2019
Merged

Switch to jenkins CI #209

merged 1 commit into from
Sep 21, 2019

Conversation

Frizi
Copy link
Member

@Frizi Frizi commented Sep 21, 2019 •
edited
Loading

Fixes #208

iOS builds are still happening on travis, but only on master branch as a sanity check (does not block merge).

@Frizi Frizi force-pushed the jenkins-ci branch 6 times, most recently from ed7f9ce to 6177bf3 Compare September 21, 2019 16:25
fhaynes
fhaynes approved these changes Sep 21, 2019
View reviewed changes
Copy link
Member

@fhaynes fhaynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok. Is there an alternative to an iOS device than travis?

@Frizi
Copy link
Member Author

Frizi commented Sep 21, 2019 •
edited
Loading

Is there an alternative to an iOS device than travis?

An iOS device on jenkins :P
Or we can just ignore iOS and rely on macOS alone.

@codecov-io
Copy link

codecov-io commented Sep 21, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@ab6e618). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #209   +/-   ##
=========================================
  Coverage          ?   87.57%           
=========================================
  Files             ?        6           
  Lines             ?      169           
  Branches          ?        0           
=========================================
  Hits              ?      148           
  Misses            ?       21           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab6e618...484bc45. Read the comment docs.

bors bot added a commit that referenced this pull request Sep 21, 2019
@bors @Frizi
Merge #209
3bcd7ec 
209: Switch to jenkins CI r=fhaynes a=Frizi

Fixes #208

iOS builds are still happening on travis, but only on master branch as a sanity check (does not block merge).

Co-authored-by: Frizi <frizi09@gmail.com>
@amethyst amethyst deleted a comment from bors bot Sep 21, 2019
@Frizi
Copy link
Member Author

Frizi commented Sep 21, 2019

bors r=fhaynes

bors bot added a commit that referenced this pull request Sep 21, 2019
@bors @Frizi
Merge #209
9e7cb21 
209: Switch to jenkins CI r=fhaynes a=Frizi

Fixes #208

iOS builds are still happening on travis, but only on master branch as a sanity check (does not block merge).

Co-authored-by: Frizi <frizi09@gmail.com>
@bors
Copy link
Contributor

bors bot commented Sep 21, 2019

Build succeeded

@bors bors bot merged commit fad2f56 into master Sep 21, 2019
@Frizi Frizi mentioned this pull request Sep 25, 2019
Merged
@ezpuzz ezpuzz deleted the jenkins-ci branch December 22, 2020 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhaynes fhaynes fhaynes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

move continuous integration stack to amethyst jenkins
3 participants
@Frizi @codecov-io @fhaynes