Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #666 #667

Merged
merged 1 commit into from
Jan 18, 2020
Merged

Fixes #666 #667

merged 1 commit into from
Jan 18, 2020

Conversation

bofh69
Copy link

@bofh69 bofh69 commented Dec 30, 2019

Checklist

  • I've added tests for all code changes and additions (where applicable)
  • I've added a demonstration of the new feature to one or more examples
  • I've updated the book to reflect my changes
  • Usage of new public items is shown in the API docs

API changes

azriel91
azriel91 approved these changes Dec 31, 2019
View reviewed changes
Copy link
Member

@azriel91 azriel91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@azriel91
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Dec 31, 2019
@bors @bofh69
Merge #667
0d81802 
667: Fixes #666 r=azriel91 a=bofh69

<!-- Before creating a PR, please make sure you read the contribution guidelines. -->
<!-- Feel free to delete points if they don't make sense for this PR. -->
<!-- You can tick boxes by putting an "x" inside the braces, or by clicking them once the comment is published. -->

<!-- Please use "Fixes #nr" and "Related #nr", respectively. -->

## Checklist

* [ ] I've added tests for all code changes and additions (where applicable)
* [ ] I've added a demonstration of the new feature to one or more examples
* [ ] I've updated the book to reflect my changes
* [ ] Usage of new public items is shown in the API docs

## API changes

<!-- Please make it clear if your change is breaking. -->


Co-authored-by: Sebastian Andersson <sebastian.andersson@lumenradio.com>
@bors
Copy link
Contributor

bors bot commented Dec 31, 2019

Build failed

@azriel91
Copy link
Member

azriel91 commented Dec 31, 2019 •
edited
Loading

Seems like rustc 1.42.0-nightly (a9dd56ff9 2019-12-30) breaks on compiling maxtrixmultiply 0.2.3, which nalgebra 0.19.0 depends on.

error: array lengths can't depend on generic parameters
   --> /home/travis/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/matrixmultiply-0.2.3/src/dgemm_kernel.rs:786:44
    |
786 |     let mut ab: [[T; NR]; MR] = [[0.; NR]; MR];
    |                                            ^^

(Likely) related:

Note: It compiles fine on rustc 1.42.0-nightly (0de96d37f 2019-12-19)

@azriel91
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Jan 18, 2020
@bors
Try #667:
70bfc44
@bors
Copy link
Contributor

bors bot commented Jan 18, 2020

try

Build succeeded

@azriel91
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Jan 18, 2020
@bors @bofh69
Merge #667
63bfb56 
667: Fixes #666 r=azriel91 a=bofh69

<!-- Before creating a PR, please make sure you read the contribution guidelines. -->
<!-- Feel free to delete points if they don't make sense for this PR. -->
<!-- You can tick boxes by putting an "x" inside the braces, or by clicking them once the comment is published. -->

<!-- Please use "Fixes #nr" and "Related #nr", respectively. -->

## Checklist

* [ ] I've added tests for all code changes and additions (where applicable)
* [ ] I've added a demonstration of the new feature to one or more examples
* [ ] I've updated the book to reflect my changes
* [ ] Usage of new public items is shown in the API docs

## API changes

<!-- Please make it clear if your change is breaking. -->


Co-authored-by: Sebastian Andersson <sebastian.andersson@lumenradio.com>
@bors
Copy link
Contributor

bors bot commented Jan 18, 2020

Build succeeded

@bors bors bot merged commit 990053e into amethyst:master Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azriel91 azriel91 azriel91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bofh69 @azriel91