Rewrite Game List in SwiftUI #40
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amiantos
commented
Apr 10, 2023
Comment on lines
+30
to
+33
| Text(game.about ?? "") | ||
| .font(.subheadline) | ||
| .frame(maxWidth: .infinity, alignment: .leading) | ||
| .padding(EdgeInsets(top: 0, leading: 22, bottom: 8, trailing: 22)) |
There was a problem hiding this comment.
This can help with text getting truncated:
Text(content)
.fixedSize(horizontal: false, vertical: true)
.frame(maxWidth: .infinity, alignment: .leading)
.font(.subheadline)
.padding(EdgeInsets(top: 0, leading: 22, bottom: 8, trailing: 22))
|
Unfortunately because we want to support iOS 13& 14 I have a feeling SwiftUI is a no go for this project for a while. |
Backing up a little, iOS 13 support doesn't mean no Swift UI, it just means not as great iOS 13-era SwiftUI. So using SwiftUI is still an option... just more complicated now probably. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kinda just for fun