Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save frames of the contact sheet #59

Merged
merged 2 commits into from
Mar 26, 2019
Merged

Save frames of the contact sheet #59

merged 2 commits into from
Mar 26, 2019

Conversation

KaiSchu
Copy link
Contributor

@KaiSchu KaiSchu commented Mar 17, 2019

The intention of this pull request is to add a feature to save the frames that are used in the contact sheet in addition.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 30.625% when pulling 749c68d on KaiSchu:master into 1e43802 on amietn:master.

@amietn
Copy link
Owner

amietn commented Mar 26, 2019

Thank you for this pull request. Much appreciated.

I will merge but will make a few changes afterwards, namely:

  • The -to option shadows the usage of -t and -o together. Will rename it.
  • There is no error message if thumbnails cannot be copied, for example if the specified directory does not exist.
  • Frames are copied outside of the specified directory if a final slash is omitted.

@amietn amietn merged commit 3157f69 into amietn:master Mar 26, 2019
amietn pushed a commit that referenced this pull request Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants