Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(n)listtree activates last entry click at bottom (free space) #1

Closed
javierdlr opened this issue Apr 25, 2017 · 5 comments
Closed

(n)listtree activates last entry click at bottom (free space) #1

javierdlr opened this issue Apr 25, 2017 · 5 comments
Assignees

Comments

@javierdlr
Copy link

As I'm not sure if it's NListtree bug I added link to such ticket http://muidev.de/ticket/349

@tboeckel tboeckel self-assigned this Apr 26, 2017
@tboeckel
Copy link
Contributor

As you stated yourself, only NList/NListtree is affected, but not MUI's internal List/Listtree class. Hence this this the correct bug tracker.

I think I found the guilty check during the quite convoluted and far over-complex mouse click handling. Please try the attached version.
NList_os3.zip
NList_os4.zip

tboeckel added a commit that referenced this issue Apr 26, 2017
… instead of activating the last entry. This refs #1.
@javierdlr
Copy link
Author

Tried OS4 version and almost ther, but when I click on bottom space the selected entry/item moves one position down (until it reaches last item on listtree).
Will reboot system and retest

@javierdlr
Copy link
Author

javierdlr commented Apr 26, 2017

Same issue even after a reboot.
See video attached, selection goes one down when I click on LMB, until end of listtree.
output.zip

Not knowing about much about coding, maybe removing (commenting out) in NList_mcc2.c
'NL_List_Active(data,MUIV_NList_Active_Down,NULL,data->selectmode,FALSE,0);' (line 819 aprox) will avoid such "select down item".

tboeckel added a commit that referenced this issue Apr 26, 2017
…low the last entry. This code is really far too convoluted to be maintainable :( This refs #1.
@tboeckel
Copy link
Contributor

The second version should fix this issue. At least I cannot make NList misbehave anymore, no matter where I click below the last entry.
NList_os3.zip
NList_os4.zip

@javierdlr
Copy link
Author

YES!!!! Seems now fixed. THX A LOT!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants