Fixing imports and making objects final

amihaiemil · Dec 26, 2018 · 768ac1c · 768ac1c
1 parent 42a47bc
commit 768ac1c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/src/main/java/com/amihaiemil/docker/RtNetworks.java b/src/main/java/com/amihaiemil/docker/RtNetworks.java
@@ -27,7 +27,9 @@
 
 import java.io.IOException;
 import java.net.URI;
-import javax.json.*;
+import javax.json.Json;
+import javax.json.JsonObject;
+import javax.json.JsonObjectBuilder;
 import org.apache.http.HttpStatus;
 import org.apache.http.client.HttpClient;
 import org.apache.http.client.methods.HttpPost;
@@ -78,7 +80,7 @@ public Network create(final String name)
     @Override
     public Network create(final String name, final JsonObject filters)
         throws IOException, UnexpectedResponseException {
-        JsonObjectBuilder json = Json.createObjectBuilder();
+        final JsonObjectBuilder json = Json.createObjectBuilder();
         json.add("Name", name);
         filters.forEach(json::add);
         return this.createNetwork(json);
@@ -138,7 +140,7 @@ private Network createNetwork(final JsonObjectBuilder json)
                     json.build().toString(), ContentType.APPLICATION_JSON
                 )
             );
-            JsonObject createResult = this.client.execute(
+            final JsonObject createResult = this.client.execute(
                 create,
                 new ReadJsonObject(
                     new MatchStatus(
@@ -147,7 +149,7 @@ private Network createNetwork(final JsonObjectBuilder json)
                     )
                 )
             );
-            if (createResult.size() > 0) {
+            if (!createResult.isEmpty()) {
                 return new RtNetwork(createResult,
                     this.client,
                     URI.create(

diff --git a/src/test/java/com/amihaiemil/docker/RtNetworksTestCase.java b/src/test/java/com/amihaiemil/docker/RtNetworksTestCase.java
@@ -102,7 +102,7 @@ public void pruneThrowsErrorOnResponse500() throws Exception {
      */
     @Test
     public void createOk() throws Exception {
-        Network network = new ListedNetworks(
+        final Network network = new ListedNetworks(
             new AssertRequest(
                 new Response(
                     HttpStatus.SC_CREATED,
@@ -150,7 +150,7 @@ public void createWithParametersOk() throws Exception {
         final JsonObject labels = Json.createObjectBuilder()
             .add("label1", "label one")
             .add("label2", "label two").build();
-        Network network =
+        final Network network =
             new ListedNetworks(
                 new AssertRequest(
                     new Response(