Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#153) Images.filter() #160

Merged
merged 1 commit into from
Oct 15, 2018
Merged

(#153) Images.filter() #160

merged 1 commit into from
Oct 15, 2018

Conversation

llorllale
Copy link
Contributor

This PR is for #153:

  • Sketch of Images.filter() in ListedImages
  • Left puzzle for implementing integration tests for RtImages.filter()

I'm also not so sure what the merge strategy should be for these filters. This PR will simply substitute any previously specified filter's values, but I'm not sure if you wanted to actually merge the values of the filters.

@llorllale llorllale mentioned this pull request Oct 10, 2018
@coveralls
Copy link

coveralls commented Oct 10, 2018

Pull Request Test Coverage Report for Build 299

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 81.873%

Totals Coverage Status
Change from base Build 298: 0.2%
Covered Lines: 411
Relevant Lines: 502

💛 - Coveralls

@0crat
Copy link
Collaborator

0crat commented Oct 10, 2018

Job #160 is now in scope, role is REV

@0crat
Copy link
Collaborator

0crat commented Oct 10, 2018

@amihaiemil/z everybody who has role REV is banned at #160; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@llorllale
Copy link
Contributor Author

@amihaiemil ping

@0crat
Copy link
Collaborator

0crat commented Oct 15, 2018

@amihaiemil/z everybody who has role REV is banned at #160; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@amihaiemil
Copy link
Owner

@llorllale looks ok, thanks! Yes, I want filters to be merged. That is, if you call Images.filter(...) times, then the final instance of Images should respect all the specified filters.

@amihaiemil
Copy link
Owner

@rultor merge it

@rultor
Copy link
Collaborator

rultor commented Oct 15, 2018

@rultor merge it

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Collaborator

rultor commented Oct 15, 2018

@rultor merge it

@amihaiemil @llorllale Oops, I failed. You can see the full log here (spent 21s)

+ set -e
+ set -o pipefail
++ dirname ./run.sh
+ cd .
+ echo 32518
+ echo '1.68 838a77339'
1.68 838a77339
+ date
Mon Oct 15 08:55:36 CEST 2018
+ uptime
 08:55:36 up 99 days, 17:39,  0 users,  load average: 2.22, 2.20, 2.17
+ ff=default
+ image=yegor256/java8
+ rebase=false
+ head_branch=master
./run.sh: line 23: syntax error near unexpected token `('
'cid' file is absent, container wasn't started correctly

@amihaiemil amihaiemil merged commit b7b567c into amihaiemil:master Oct 15, 2018
@0crat
Copy link
Collaborator

0crat commented Oct 15, 2018

Job gh:amihaiemil/docker-java-api#160 is not assigned, can't get performer

@0crat
Copy link
Collaborator

0crat commented Oct 15, 2018

The job #160 is now out of scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants