-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#153) Images.filter() #160
Conversation
Pull Request Test Coverage Report for Build 299
💛 - Coveralls |
Job #160 is now in scope, role is |
@amihaiemil ping |
@llorllale looks ok, thanks! Yes, I want filters to be merged. That is, if you call |
@rultor merge it |
@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here |
@amihaiemil @llorllale Oops, I failed. You can see the full log here (spent 21s)
|
Job |
The job #160 is now out of scope |
This PR is for #153:
Images.filter()
inListedImages
RtImages.filter()
I'm also not so sure what the merge strategy should be for these filters. This PR will simply substitute any previously specified filter's values, but I'm not sure if you wanted to actually merge the values of the filters.